You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2021/06/14 06:55:50 UTC
[isis] branch master updated: ISIS-2738: MM diff report: forgot to
add 'value' in prev.commit
This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git
The following commit(s) were added to refs/heads/master by this push:
new 4ecba47 ISIS-2738: MM diff report: forgot to add 'value' in prev.commit
4ecba47 is described below
commit 4ecba4796dca52ff50a5a3406a28d5caeebc8953
Author: Andi Huber <ah...@apache.org>
AuthorDate: Mon Jun 14 08:55:39 2021 +0200
ISIS-2738: MM diff report: forgot to add 'value' in prev.commit
---
.../apache/isis/applib/services/metamodel/_DiffExport.java | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/api/applib/src/main/java/org/apache/isis/applib/services/metamodel/_DiffExport.java b/api/applib/src/main/java/org/apache/isis/applib/services/metamodel/_DiffExport.java
index 66101f2..0d21d27 100644
--- a/api/applib/src/main/java/org/apache/isis/applib/services/metamodel/_DiffExport.java
+++ b/api/applib/src/main/java/org/apache/isis/applib/services/metamodel/_DiffExport.java
@@ -225,19 +225,19 @@ class _DiffExport {
private void reportFacetNotInOther(DiffModel diffModel, String symbol, String typeOrMemberId, Facet facet) {
val sb = diffModel.sb;
- val attrKeyValueLiterals = streamFacetAttr(facet)
- .map(attr->attr.getName())
+ val attrNameValueLiterals = streamFacetAttr(facet)
+ .map(attr->attr.getName() + " " + attr.getValue())
.collect(Can.toCan());
// even if there are no attributes, we still want to report that there is a difference with facets
- val attrKeyValueOrEmptyLiterals =
- attrKeyValueLiterals.isEmpty()
+ val attrNameValueOrEmptyLiterals =
+ attrNameValueLiterals.isEmpty()
? Can.of("<no-attributes>")
- : attrKeyValueLiterals;
+ : attrNameValueLiterals;
- attrKeyValueOrEmptyLiterals.forEach(attrKeyValueLiteral->{
+ attrNameValueOrEmptyLiterals.forEach(attrNameValueLiteral->{
sb.append(symbol).append(" ").append(typeOrMemberId)
- .append(" ").append(attrKeyValueLiteral)
+ .append(" ").append(attrNameValueLiteral)
.append("\n");
});
diffModel.diffCout++;