You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/05 07:25:33 UTC

[GitHub] [spark] maropu commented on a change in pull request #31752: [SPARK-34634][SQL] ResolveReferences.dedupRight should handle ScriptTransformation

maropu commented on a change in pull request #31752:
URL: https://github.com/apache/spark/pull/31752#discussion_r588082907



##########
File path: sql/core/src/test/resources/sql-tests/inputs/selfjoin-with-transform.sql
##########
@@ -0,0 +1,6 @@
+create temporary view t as select * from values 0, 1, 2 as t(a);
+
+WITH temp AS (

Review comment:
       Could you move this test into `transform.sql`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org