You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org> on 2008/10/31 17:41:44 UTC
[jira] Commented: (TAP5-184) Improve error reporting when a
javascript asset is intended to be included on page which has no
element
[ https://issues.apache.org/jira/browse/TAP5-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644341#action_12644341 ]
Howard M. Lewis Ship commented on TAP5-184:
-------------------------------------------
Yes; I think this should be an error, not just skipped logic. It would be clearer as an error.
> Improve error reporting when a javascript asset is intended to be included on page which has no <body> element
> --------------------------------------------------------------------------------------------------------------
>
> Key: TAP5-184
> URL: https://issues.apache.org/jira/browse/TAP5-184
> Project: Tapestry 5
> Issue Type: Improvement
> Affects Versions: 5.0.15
> Reporter: Michael Lake
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> I know - silly of me to have a page with no <body></body> element. I spent an entire day trying to figure out why the javascript wasn't getting included.
> It was my error, but I can see other people making the same mistake...a little error-reporting would be nice.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
Re: [jira] Commented: (TAP5-184) Improve error reporting when a javascript
asset is intended to be included on page which has no element
Posted by Fernando Padilla <fe...@alum.mit.edu>.
The thing is that we don't just publish to html, we also publish to html
fragments (<div>), fbml (facebook, <fbml>), and even json (packaging
kind of like partial render). So i want to make sure that if you do
decide this is an error, not make it a fatal error, and make it so we
can turn off the logging on it, since that might fail often.
Also, we had a hard time trying to properly override the RenderSupport
and MarkupRenderFilter structure to properly handle the other options of
rendering. If we had a good way to change contributions it would be
much easier (we could replace standard RenderSupport with ours). Or if
the RenderSupport was somehow a service we could decorate it would be
much easier, etc etc.. :) :)
Howard M. Lewis Ship (JIRA) wrote:
> [ https://issues.apache.org/jira/browse/TAP5-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12644341#action_12644341 ]
>
> Howard M. Lewis Ship commented on TAP5-184:
> -------------------------------------------
>
> Yes; I think this should be an error, not just skipped logic. It would be clearer as an error.
>
>> Improve error reporting when a javascript asset is intended to be included on page which has no <body> element
>> --------------------------------------------------------------------------------------------------------------
>>
>> Key: TAP5-184
>> URL: https://issues.apache.org/jira/browse/TAP5-184
>> Project: Tapestry 5
>> Issue Type: Improvement
>> Affects Versions: 5.0.15
>> Reporter: Michael Lake
>> Assignee: Howard M. Lewis Ship
>> Priority: Minor
>>
>> I know - silly of me to have a page with no <body></body> element. I spent an entire day trying to figure out why the javascript wasn't getting included.
>> It was my error, but I can see other people making the same mistake...a little error-reporting would be nice.
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org