You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/11/08 09:15:18 UTC
[GitHub] [iotdb] HeimingZ opened a new pull request #4336: [IOTDB-1958] Add storage group not ready exception
HeimingZ opened a new pull request #4336:
URL: https://github.com/apache/iotdb/pull/4336
There are too many logs like "sg may not ready now ", so i add StorageGroupNotReadyException and exclude it from server log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HeimingZ commented on a change in pull request #4336: [To rel/0.12][IOTDB-1958] Add storage group not ready exception
Posted by GitBox <gi...@apache.org>.
HeimingZ commented on a change in pull request #4336:
URL: https://github.com/apache/iotdb/pull/4336#discussion_r744534432
##########
File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
##########
@@ -1944,10 +1943,12 @@ private TSStatus tryCatchNonQueryException(Exception e) {
LOGGER.warn(message, e);
return RpcUtils.getStatus(Arrays.asList(((BatchProcessException) e).getFailingStatus()));
} else if (e instanceof IoTDBException) {
- if (((IoTDBException) e).isUserException()) {
- LOGGER.warn(message + e.getMessage());
- } else {
- LOGGER.warn(message, e);
+ if (!(e instanceof StorageGroupNotReadyException)) {
Review comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #4336: [To rel/0.12][IOTDB-1958] Add storage group not ready exception
Posted by GitBox <gi...@apache.org>.
HTHou merged pull request #4336:
URL: https://github.com/apache/iotdb/pull/4336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #4336: [To rel/0.12][IOTDB-1958] Add storage group not ready exception
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #4336:
URL: https://github.com/apache/iotdb/pull/4336#discussion_r744532584
##########
File path: server/src/main/java/org/apache/iotdb/db/service/TSServiceImpl.java
##########
@@ -1944,10 +1943,12 @@ private TSStatus tryCatchNonQueryException(Exception e) {
LOGGER.warn(message, e);
return RpcUtils.getStatus(Arrays.asList(((BatchProcessException) e).getFailingStatus()));
} else if (e instanceof IoTDBException) {
- if (((IoTDBException) e).isUserException()) {
- LOGGER.warn(message + e.getMessage());
- } else {
- LOGGER.warn(message, e);
+ if (!(e instanceof StorageGroupNotReadyException)) {
Review comment:
} else if (e instanceof IoTDBException && !(e instanceof StorageGroupNotReadyException)) {
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org