[GitHub] [incubator-superset] ktmud commented on a change in pull request #11491: feat: globally disable underscore for links in menu items

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #11491:
URL: https://github.com/apache/incubator-superset/pull/11491#discussion_r514619334



##########
File path: superset-frontend/src/common/components/index.tsx
##########
@@ -17,16 +17,35 @@
  * under the License.
  */
 import { styled } from '@superset-ui/core';
+// eslint-disable-next-line no-restricted-imports
 import { Skeleton } from 'antd';
+import AntdMenuItem from 'antd/lib/menu/MenuItem';
 
 /*
-  Antd is exported from here so we can override components with Emotion as needed.
+  Antd is re-exported from here so we can override components with Emotion as needed.
 
   For documentation, see https://ant.design/components/overview/
  */
-/* eslint no-restricted-imports: 0 */
+// eslint-disable-next-line no-restricted-imports
+export {
+  Avatar,
+  Card,
+  Collapse,
+  Empty,
+  Dropdown,
+  Menu,
+  Modal,
+  Popover,
+  Skeleton,
+  Tabs,
+  Tooltip,
+} from 'antd';
 
-export * from 'antd';
+export const MenuItem = styled(AntdMenuItem)`

Review comment:
       I tried direct assignment and it breaks typing. 
   
   Sure, but I think it's still important to explicitly export `antd` components and potentially make it possible to import other overrides `from "src/common/components"`, otherwise there is no difference between `import { x } from "src/common/components"` than directly importing from `antd`.
    




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org