You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/16 09:44:07 UTC

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request, #1352: Make.defs: Change "ifeq ($(XXX),y)" to "ifneq ($(XXX),)

xiaoxiang781216 opened a new pull request, #1352:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1352

   ## Summary
   to support the tristate option correctly and unify the usage
   
   ## Impact
   Minor, code refactor only
   
   ## Testing
   Pass CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1352: Make.defs: Change "ifeq ($(XXX),y)" to "ifneq ($(XXX),)

Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #1352:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1352


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1352: Make.defs: Change "ifeq ($(XXX),y)" to "ifneq ($(XXX),)

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #1352:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1352#issuecomment-1279961470

   > Why not change to `ifneq ($(CONFIG_XXX),n)`?
   
   tristate has three possible value(y, m, n), only n can skip the build, both y and m need continue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on pull request #1352: Make.defs: Change "ifeq ($(XXX),y)" to "ifneq ($(XXX),)

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #1352:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1352#issuecomment-1279964705

   > > Why not change to `ifneq ($(CONFIG_XXX),n)`?
   > 
   > tristate has three possible values(y, m, n), only n(empty) can skip the build, both y and m need continue.
   
   Yeah, missed that `n` does not generate anything


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org