[jira] Commented: (CASSANDRA-1565) cassandra-cli use consistant flags and improve error messages

["Christoph Hack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983295#action_12983295 ] 

Christoph Hack commented on CASSANDRA-1565:
-------------------------------------------

Hi Pavel, many thanks for reviewing this patch.

I haven't used options.addOption("", ...) because this result in ugly empty short argument names (like "-,--debug") in the formatter, and second you can not set the argument names to more meaningful values. Please consider this, while reviewing. Using the OptionBuilder is sighly more work, but the result is better in my opinion.

> cassandra-cli use consistant flags and improve error messages
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-1565
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-1565
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>         Environment: Centos 5 using http://mirror.lividpenguin.com/pub/apache//cassandra/0.7.0/apache-cassandra-0.7.0-beta1-bin.tar.gz
>            Reporter: Ian Rogers
>            Assignee: Pavel Yaskevich
>            Priority: Minor
>             Fix For: 0.8
>
>         Attachments: CASSANDRA-1565.patch, trunk-1565.txt
>
>
> nodetool uses "-h" to specify the host to connect to but cassandra-cli uses "-host" which is a pain to remember.
> More importantly, if you do use "-h" then there's no error!  If you do this and then try to "show keyspaces" or some such you just get an entirely accurate though confusing "not connected to a cluster" error.
> 1. Make the flags consistant amongst all the tools where appropriate.
> 2. If you supply a flag to a tool it doesn't recognise then the tool should error immediately and display its usage message.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.