[GitHub] [flink] twalthr commented on a change in pull request #8762: [FLINK-12844][table-planner-blink] Use default conversion class LocalDate/LocalTime/LocalDateTime for DateType/TimeType/TimestampType in blink

[GitBox <gi...@apache.org>]

twalthr commented on a change in pull request #8762: [FLINK-12844][table-planner-blink] Use default conversion class LocalDate/LocalTime/LocalDateTime for DateType/TimeType/TimestampType in blink
URL: https://github.com/apache/flink/pull/8762#discussion_r300958720
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/codegen/CodeGeneratorContext.scala
 ##########
 @@ -500,7 +527,7 @@ class CodeGeneratorContext(val tableConfig: TableConfig) {
     * Adds a reusable TimeZone to the member area of the generated class.
     */
   def addReusableTimeZone(): String = {
 
 Review comment:
   @JingsongLi Maybe we should update `TableConfig` and use `ZoneId` instead of the old `TimeZone` class. I haven't looked in to the details but I read: "A {@code ZoneId} is used to identify the rules used to convert between
   an {@link Instant} and a {@link LocalDateTime}."

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services