You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2021/11/26 03:06:10 UTC
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1448: [KYUUBI #1446] Decouple zookeeper from abstract ServiceDiscovery
codecov-commenter commented on pull request #1448:
URL: https://github.com/apache/incubator-kyuubi/pull/1448#issuecomment-979653709
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1448?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1448](https://codecov.io/gh/apache/incubator-kyuubi/pull/1448?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (29f1cb8) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c85d64065e099668533415b53af1edcb91388626?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c85d640) will **increase** coverage by `0.29%`.
> The diff coverage is `58.06%`.
> :exclamation: Current head 29f1cb8 differs from pull request most recent head 06a7a6f. Consider uploading reports for the commit 06a7a6f to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1448 +/- ##
============================================
+ Coverage 58.88% 59.18% +0.29%
- Complexity 155 172 +17
============================================
Files 232 236 +4
Lines 11931 12047 +116
Branches 1460 1474 +14
============================================
+ Hits 7026 7130 +104
- Misses 4313 4314 +1
- Partials 592 603 +11
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1448?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...cala/org/apache/kyuubi/ctl/ServiceControlCli.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1448/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvU2VydmljZUNvbnRyb2xDbGkuc2NhbGE=) | `74.74% <ø> (ø)` | |
| [...la/org/apache/kyuubi/ha/HighAvailabilityConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1448/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL0hpZ2hBdmFpbGFiaWxpdHlDb25mLnNjYWxh) | `98.85% <ø> (ø)` | |
| [...ubi/ha/client/zookeeper/ZooKeeperACLProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1448/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC96b29rZWVwZXIvWm9vS2VlcGVyQUNMUHJvdmlkZXIuc2NhbGE=) | `85.00% <ø> (ø)` | |
| [...yuubi/ha/client/zookeeper/ZooKeeperAuthTypes.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1448/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC96b29rZWVwZXIvWm9vS2VlcGVyQXV0aFR5cGVzLnNjYWxh) | `100.00% <ø> (ø)` | |
| [.../ha/client/zookeeper/ZooKeeperClientProvider.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1448/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC96b29rZWVwZXIvWm9vS2VlcGVyQ2xpZW50UHJvdmlkZXIuc2NhbGE=) | `70.17% <ø> (ø)` | |
| [...ache/kyuubi/engine/spark/SparkProcessBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1448/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvc3BhcmsvU3BhcmtQcm9jZXNzQnVpbGRlci5zY2FsYQ==) | `87.00% <ø> (ø)` | |
| [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1448/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `62.66% <ø> (+1.55%)` | :arrow_up: |
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1448/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `84.72% <ø> (ø)` | |
| [.../ha/client/zookeeper/ZooKeeperInstanceClient.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1448/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC96b29rZWVwZXIvWm9vS2VlcGVySW5zdGFuY2VDbGllbnQuc2NhbGE=) | `46.80% <46.80%> (ø)` | |
| [...ache/kyuubi/ha/client/EngineServiceDiscovery.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1448/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9FbmdpbmVTZXJ2aWNlRGlzY292ZXJ5LnNjYWxh) | `50.00% <50.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/1448/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1448?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1448?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c85d640...06a7a6f](https://codecov.io/gh/apache/incubator-kyuubi/pull/1448?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org