[jira] [Resolved] (IMPALA-11257) Fix CMake warnings for module names and cmake_minimum_required

["Joe McDonnell (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/IMPALA-11257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe McDonnell resolved IMPALA-11257.
------------------------------------
    Fix Version/s: Impala 4.2.0
       Resolution: Fixed

> Fix CMake warnings for module names and cmake_minimum_required
> --------------------------------------------------------------
>
>                 Key: IMPALA-11257
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11257
>             Project: IMPALA
>          Issue Type: Task
>          Components: Infrastructure
>    Affects Versions: Impala 4.1.0
>            Reporter: Joe McDonnell
>            Assignee: Joe McDonnell
>            Priority: Minor
>             Fix For: Impala 4.2.0
>
>
> CMake produces warnings during the build. One flavor is complaints about the package names for various cmake_modules. The other flavor is complaining about cmake_minimum_required calls with old versions of CMake.
> {noformat}
> CMake Warning (dev) at /opt/Impala-Toolchain/toolchain-packages-gcc7.5.0/cmake-3.22.2/share/cmake-3.22/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
>   The package name passed to `find_package_handle_standard_args` (PROTOBUF)
>   does not match the name of the calling package (Protobuf).  This can lead
>   to problems in calling code that expects `find_package` result variables
>   (e.g., `_FOUND`) to follow a certain pattern.
> ...
> CMake Deprecation Warning at common/thrift/CMakeLists.txt:19 (cmake_minimum_required):
>   Compatibility with CMake < 2.8.12 will be removed from a future version of
>   CMake.{noformat}
> These are ugly and spam the logs. We should fix these.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)