[GitHub] [skywalking] lujiajing1126 commented on a change in pull request #7458: Complete banyandb client

[GitBox <gi...@apache.org>]

lujiajing1126 commented on a change in pull request #7458:
URL: https://github.com/apache/skywalking/pull/7458#discussion_r689102860



##########
File path: oap-server/banyandb-java-client/src/main/java/org/apache/skywalking/banyandb/v1/client/PairQueryCondition.java
##########
@@ -20,39 +20,288 @@
 
 import org.apache.skywalking.banyandb.v1.Banyandb;
 
-import static org.apache.skywalking.banyandb.v1.Banyandb.PairQuery.BinaryOp.BINARY_OP_EQ;
+import java.util.List;
 
 /**
  * PairQuery represents a query condition, including field name, operator, and value(s);
  */
-public abstract class PairQueryCondition {
-    protected String fieldName;
+public abstract class PairQueryCondition<T> extends FieldAndValue<T> {
+    protected final org.apache.skywalking.banyandb.v1.Banyandb.PairQuery.BinaryOp op;
 
-    protected abstract Banyandb.PairQuery build();
+    private PairQueryCondition(String fieldName, Banyandb.PairQuery.BinaryOp op, T value) {

Review comment:
       Fixed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org