[GitHub] [pinot] klsince commented on a diff in pull request #11694: Minor improvement to upsert preload

["klsince (via GitHub)" <gi...@apache.org>]

klsince commented on code in PR #11694:
URL: https://github.com/apache/pinot/pull/11694#discussion_r1338069514


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BaseTableUpsertMetadataManager.java:
##########
@@ -162,12 +162,14 @@ private void preloadSegments()
     LOGGER.info("Preload segments from table: {} for fast upsert metadata recovery", _tableNameWithType);
     onPreloadStart();
     IdealState idealState = HelixHelper.getTableIdealState(_helixManager, _tableNameWithType);
+    Preconditions.checkState(idealState != null, "Failed to find ideal state for table: %s", _tableNameWithType);

Review Comment:
   hmm.. NPE didn't get printed by the warn log at L137 above? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org