You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2016/06/16 00:34:12 UTC

[GitHub] zeppelin pull request #1019: [ZEPPELIN-1015] Cron job fails to run a paragra...

GitHub user Leemoonsoo opened a pull request:

    https://github.com/apache/zeppelin/pull/1019

    [ZEPPELIN-1015] Cron job fails to run a paragraph when multiple type of interpreter is being used

    ### What is this PR for?
    Cron job can fail when notebook uses multiple types of paragraphs.
    Problem reported here http://apache-zeppelin-users-incubating-mailing-list.75479.x6.nabble.com/Cron-job-fails-to-run-a-paragraph-that-runs-correctly-manually-tt2265.html
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    * [x] - Fix
    * [x] - Unittest
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1015
    
    ### How should this be tested?
    Create two paragraphs in the notebook
    First takes longer than second (last) paragraph.
    First paragraph and second paragraph should use different interpreter.
    
    If cron schedule the notebook with 'auto-restart interpreter on cron execution' checked.
    Then interpreters will be restarted when second paragraph finished, but first paragraph is still running.
    That may cause abort of first paragraph run.
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-1015

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1019.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1019
    
----
commit f6e61437445b17a26ae83aa38c743d66ee08df90
Author: Lee moon soo <mo...@apache.org>
Date:   2016-06-16T00:30:17Z

    Fix problem by waiting all paragraphs in note be finished

commit 07886418e94e9f699a8a4206d8470085acde5744
Author: Lee moon soo <mo...@apache.org>
Date:   2016-06-16T00:30:38Z

    Update unittest to reproduce the problem

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1019: [ZEPPELIN-1015] Cron job fails to run a paragraph when...

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/1019
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1019: [ZEPPELIN-1015] Cron job fails to run a paragraph when...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1019
  
    @jmrr Thanks for verifying!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1019: [ZEPPELIN-1015] Cron job fails to run a paragra...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1019


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1019: [ZEPPELIN-1015] Cron job fails to run a paragraph when...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/1019
  
    Rebased to resolve conflicts to master.
    Thanks @felixcheung and @cloverhearts for review.
    Merge if there're no more discussions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1019: [ZEPPELIN-1015] Cron job fails to run a paragraph when...

Posted by jmrr <gi...@git.apache.org>.
Github user jmrr commented on the issue:

    https://github.com/apache/zeppelin/pull/1019
  
    LGTM too, thanks @Leemoonsoo I've also tried with same interpreter and also works


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1019: [ZEPPELIN-1015] Cron job fails to run a paragraph when...

Posted by cloverhearts <gi...@git.apache.org>.
Github user cloverhearts commented on the issue:

    https://github.com/apache/zeppelin/pull/1019
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---