You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by ja...@apache.org on 2014/05/20 05:01:54 UTC
[06/14] git commit: DRILL-771: Remove explicit cast to varchar for
concat() function; implicit cast will be used.
DRILL-771: Remove explicit cast to varchar for concat() function; implicit cast will be used.
Project: http://git-wip-us.apache.org/repos/asf/incubator-drill/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-drill/commit/492ec59c
Tree: http://git-wip-us.apache.org/repos/asf/incubator-drill/tree/492ec59c
Diff: http://git-wip-us.apache.org/repos/asf/incubator-drill/diff/492ec59c
Branch: refs/heads/master
Commit: 492ec59c17d718bfb0891a249f9e7a841372fad8
Parents: 62c0b1b
Author: Mehant Baid <me...@gmail.com>
Authored: Sun May 18 19:18:51 2014 -0700
Committer: Mehant Baid <me...@gmail.com>
Committed: Mon May 19 10:43:31 2014 -0700
----------------------------------------------------------------------
.../org/apache/drill/exec/planner/logical/DrillOptiq.java | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-drill/blob/492ec59c/exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java
----------------------------------------------------------------------
diff --git a/exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java b/exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java
index 7efd714..e900fc2 100644
--- a/exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java
+++ b/exec/java-exec/src/main/java/org/apache/drill/exec/planner/logical/DrillOptiq.java
@@ -301,16 +301,15 @@ public class DrillOptiq {
// Cast arguments to VARCHAR
List<LogicalExpression> concatArgs = Lists.newArrayList();
- MajorType castType = Types.required(MinorType.VARCHAR).toBuilder().setWidth(64000).build();
- concatArgs.add(FunctionCallFactory.createCast(castType, ExpressionPosition.UNKNOWN, args.get(0)));
- concatArgs.add(FunctionCallFactory.createCast(castType, ExpressionPosition.UNKNOWN, args.get(1)));
+ concatArgs.add(args.get(0));
+ concatArgs.add(args.get(1));
LogicalExpression first = FunctionCallFactory.createExpression(functionName, concatArgs);
for (int i = 2; i < args.size(); i++) {
concatArgs = Lists.newArrayList();
concatArgs.add(first);
- concatArgs.add(FunctionCallFactory.createCast(castType, ExpressionPosition.UNKNOWN, args.get(i)));
+ concatArgs.add(args.get(i));
first = FunctionCallFactory.createExpression(functionName, concatArgs);
}