[GitHub] andrzej-kaczmarek commented on a change in pull request #9: nimble/ll: Do not use sec_txdone for legacy adv

[GitBox <gi...@apache.org>]

andrzej-kaczmarek commented on a change in pull request #9: nimble/ll: Do not use sec_txdone for legacy adv
URL: https://github.com/apache/mynewt-nimble/pull/9#discussion_r177687273
 
 

 ##########
 File path: nimble/controller/src/ble_ll_adv.c
 ##########
 @@ -1323,7 +1323,9 @@ ble_ll_adv_halt(void)
 
         os_eventq_put(&g_ble_ll_data.ll_evq, &advsm->adv_txdone_ev);
 #if MYNEWT_VAL(BLE_LL_CFG_FEAT_LL_EXT_ADV)
-        os_eventq_put(&g_ble_ll_data.ll_evq, &advsm->adv_sec_txdone_ev);
+        if (!(advsm->props & BLE_HCI_LE_SET_EXT_ADV_PROP_LEGACY)) {
 
 Review comment:
   ble_ll_adv_tx_done() is called from ISR where we need to figure out which chanset has just finished transmission and act accordingly. here we just want to stop everything thus is does not matter which chanset is active - just stop all that could be active.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services