You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2019/10/24 19:55:16 UTC

[GitHub] [couchdb] iilyak opened a new pull request #2279: Pass contexts to fabric2_db functions

iilyak opened a new pull request #2279: Pass contexts to fabric2_db functions
URL: https://github.com/apache/couchdb/pull/2279
 
 
   ## Overview
   
   Since the db structure returned from fabric2_db:open and fabric2_db:create
   includes `user_ctx` there is no need to pass it explicitly
   in every `fabric2_db` call. This means we can simplify few things:
   
   - Don't pass user_ctx in `chttpd_db:db_req/2` since we pass db already
   - Don't have to use `db_open_options` in `chttpd_changes`
   - Don't have to pass `user_ctx` to `fabric2_db:open_doc` and `fabric2_db:update_doc`
   
   ## Testing recommendations
   
   ```
   make eunit apps=fabric
   ```
   
   ## Related Issues or Pull Requests
   
   N/A
   
   ## Checklist
   
   - [x] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services