You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "maskit (via GitHub)" <gi...@apache.org> on 2023/03/21 00:51:22 UTC
[GitHub] [trafficserver] maskit opened a new pull request, #9546: Fix a build issue with the latest BoringSSL
maskit opened a new pull request, #9546:
URL: https://github.com/apache/trafficserver/pull/9546
```
TLSSessionResumptionSupport.cc:243:7: error: use of undeclared identifier 'HMAC_Init_ex'
if (HMAC_Init_ex(hctx, most_recent_key.hmac_secret, sizeof(most_recent_key.hmac_secret), evp_md_func, nullptr) != 1) {
^
TLSSessionResumptionSupport.cc:278:11: error: use of undeclared identifier 'HMAC_Init_ex'
if (HMAC_Init_ex(hctx, keyblock->keys[i].hmac_secret, sizeof(keyblock->keys[i].hmac_secret), evp_md_func, nullptr) != 1) {
^
2 errors generated.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit merged pull request #9546: Fix a build issue with the latest BoringSSL
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit merged PR #9546:
URL: https://github.com/apache/trafficserver/pull/9546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] maskit commented on pull request #9546: Fix a build issue with the latest BoringSSL
Posted by "maskit (via GitHub)" <gi...@apache.org>.
maskit commented on PR #9546:
URL: https://github.com/apache/trafficserver/pull/9546#issuecomment-1477156182
Second commit fixes #9545.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #9546: Fix a build issue with the latest BoringSSL
Posted by "zwoop (via GitHub)" <gi...@apache.org>.
zwoop commented on PR #9546:
URL: https://github.com/apache/trafficserver/pull/9546#issuecomment-1492579057
Cherry-picked to v9.2.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bryancall commented on a diff in pull request #9546: Fix a build issue with the latest BoringSSL
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall commented on code in PR #9546:
URL: https://github.com/apache/trafficserver/pull/9546#discussion_r1145035882
##########
iocore/net/SSLUtils.cc:
##########
@@ -527,15 +527,21 @@ DH_get_2048_256()
0x1D, 0xB2, 0x46, 0xC3, 0x2F, 0x63, 0x07, 0x84, 0x90, 0xF0, 0x0E, 0xF8, 0xD6, 0x47, 0xD1, 0x48, 0xD4, 0x79, 0x54, 0x51,
0x5E, 0x23, 0x27, 0xCF, 0xEF, 0x98, 0xC5, 0x82, 0x66, 0x4B, 0x4C, 0x0F, 0x6C, 0xC4, 0x16, 0x59};
DH *dh;
+ BIGNUM *p;
+ BIGNUM *g;
- if ((dh = DH_new()) == nullptr)
- return (nullptr);
- dh->p = BN_bin2bn(dh2048_p, sizeof(dh2048_p), nullptr);
- dh->g = BN_bin2bn(dh2048_g, sizeof(dh2048_g), nullptr);
- if ((dh->p == nullptr) || (dh->g == nullptr)) {
+ if ((dh = DH_new()) == nullptr) {
+ return nullptr;
+ }
+ p = BN_bin2bn(dh2048_p, sizeof(dh2048_p), nullptr);
+ g = BN_bin2bn(dh2048_g, sizeof(dh2048_g), nullptr);
+ if (p == nullptr || g == nullptr) {
DH_free(dh);
- return (nullptr);
+ BN_free(p);
+ BN_free(g);
+ return nullptr;
}
+ DH_set0_pqg(dh, p, nullptr, g);
Review Comment:
For reference: https://www.openssl.org/docs/man3.0/man3/DH_set0_pqg.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org