You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/11/03 14:13:57 UTC
[GitHub] [beam] snkalinin opened a new pull request #15878: [BEAM-13173][Playground] Frontend Application CI/CD Scripts
snkalinin opened a new pull request #15878:
URL: https://github.com/apache/beam/pull/15878
Add github actions workflow to build application.
Steps that performed by that workflow:
* Perform lint over go code
* Perform tests via gradle task
* Perform lint over Dockerfile
* Perform Playground Frontend application build operation and push it to Artifact Registry
* Call Terraform script to deploy application to GCP App Engine
Following secrets should be set up in registry to support that CI
`GCP_ACCESS_KEY` - base64 encoded JSON key for service account
`REGISTRY_NAME` - Docker Registry address
`PROJECT_ID` - GCP Project ID
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
`ValidatesRunner` compliance status (on master branch)
--------------------------------------------------------
<table>
<thead>
<tr>
<th>Lang</th>
<th>ULR</th>
<th>Dataflow</th>
<th>Flink</th>
<th>Samza</th>
<th>Spark</th>
<th>Twister2</th>
</tr>
</thead>
<tbody>
<tr>
<td>Go</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
</a>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>Java</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/badge/icon?subject=V1+Streaming">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon?subject=V1+Java+11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/badge/icon?subject=V2+Streaming">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon?subject=Java+8">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/icon?subject=Java+11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon?subject=Portable+Streaming">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Samza/lastCompletedBuild/badge/icon?subject=Portable">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon?subject=Structured+Streaming">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Python</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon?subject=ValCont">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>XLang</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
</tbody>
</table>
Examples testing status on various runners
--------------------------------------------------------
<table>
<thead>
<tr>
<th>Lang</th>
<th>ULR</th>
<th>Dataflow</th>
<th>Flink</th>
<th>Samza</th>
<th>Spark</th>
<th>Twister2</th>
</tr>
</thead>
<tbody>
<tr>
<td>Go</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>Java</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/badge/icon?subject=V1+Java11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>Python</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>XLang</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
</tbody>
</table>
Post-Commit SDK/Transform Integration Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>Go</th>
<th>Java</th>
<th>Python</th>
</tr>
</thead>
<tbody>
<tr>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon?subject=3.6">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon?subject=3.7">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon?subject=3.8">
</a>
</td>
</tr>
</tbody>
</table>
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>---</th>
<th>Java</th>
<th>Python</th>
<th>Go</th>
<th>Website</th>
<th>Whitespace</th>
<th>Typescript</th>
</tr>
</thead>
<tbody>
<tr>
<td>Non-portable</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon?subject=Tests">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon?subject=Lint">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon?subject=Docker">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/badge/icon?subject=Docs">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Portable</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
</tbody>
</table>
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] snkalinin commented on pull request #15878: [BEAM-13173][Playground] Frontend Application CI/CD Scripts
Posted by GitBox <gi...@apache.org>.
snkalinin commented on pull request #15878:
URL: https://github.com/apache/beam/pull/15878#issuecomment-959193428
R: @tvalentyn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] snkalinin commented on pull request #15878: [BEAM-13173][Playground] Frontend Application CI/CD Scripts
Posted by GitBox <gi...@apache.org>.
snkalinin commented on pull request #15878:
URL: https://github.com/apache/beam/pull/15878#issuecomment-959193428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a change in pull request #15878: [BEAM-13173][Playground] Frontend Application CI/CD Scripts
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on a change in pull request #15878:
URL: https://github.com/apache/beam/pull/15878#discussion_r743804258
##########
File path: .github/workflows/build_playground_frontend.yml
##########
@@ -0,0 +1,77 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Build And Deploy Playground Frontend Application
+
+on:
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ pull_request:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ paths: ['playground/backend/**']
+ workflow_dispatch:
+
+jobs:
+ build_playground_frontend_docker_image:
+ name: Build Playground Frontend App
+ runs-on: ubuntu-latest
+ env:
+ GO_VERSION: 1.17.0
+ BEAM_VERSION: 2.33.0
+ steps:
+ - name: Check out the repo
+ uses: actions/checkout@v2
+ - name: Set up JDK 1.8
+ uses: joschi/setup-jdk@v2
+ with:
+ java-version: '8'
+ - name: install flutter
+ uses: subosito/flutter-action@v1
+ with:
+ channel: 'stable'
+ - name: Prepare Flutter lint
+ run: "flutter pub add flutter_lints --dev"
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: Run Lint
+ run: "flutter analyze"
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: Run Tests
+ run: flutter test
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: install npm
+ uses: actions/setup-node@v2
+ with:
+ node-version: '14'
+ - name: install docker linter
+ run: npm install -g dockerlint
+ - name: lint dockerfile
+ run: dockerlint Dockerfile
+ working-directory: playground/frontend
+ - name: Setup GCP account
+ run: echo ${{ secrets.GCP_ACCESS_KEY }} | base64 -d > /tmp/gcp_access.json
Review comment:
Where are the secrets/passwords coming from? Are they going to be visible in the GH action logs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] snkalinin commented on a change in pull request #15878: [BEAM-13173][Playground] Frontend Application CI/CD Scripts
Posted by GitBox <gi...@apache.org>.
snkalinin commented on a change in pull request #15878:
URL: https://github.com/apache/beam/pull/15878#discussion_r744509623
##########
File path: .github/workflows/build_playground_frontend.yml
##########
@@ -0,0 +1,77 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Build And Deploy Playground Frontend Application
+
+on:
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ pull_request:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ paths: ['playground/backend/**']
+ workflow_dispatch:
+
+jobs:
+ build_playground_frontend_docker_image:
+ name: Build Playground Frontend App
+ runs-on: ubuntu-latest
+ env:
+ GO_VERSION: 1.17.0
+ BEAM_VERSION: 2.33.0
+ steps:
+ - name: Check out the repo
+ uses: actions/checkout@v2
+ - name: Set up JDK 1.8
+ uses: joschi/setup-jdk@v2
+ with:
+ java-version: '8'
+ - name: install flutter
+ uses: subosito/flutter-action@v1
+ with:
+ channel: 'stable'
+ - name: Prepare Flutter lint
+ run: "flutter pub add flutter_lints --dev"
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: Run Lint
+ run: "flutter analyze"
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: Run Tests
+ run: flutter test
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: install npm
+ uses: actions/setup-node@v2
+ with:
+ node-version: '14'
+ - name: install docker linter
+ run: npm install -g dockerlint
+ - name: lint dockerfile
+ run: dockerlint Dockerfile
+ working-directory: playground/frontend
+ - name: Setup GCP account
+ run: echo ${{ secrets.GCP_ACCESS_KEY }} | base64 -d > /tmp/gcp_access.json
Review comment:
Secrets comming from secrets section from repository settings, and output of values of secrets would be hidden
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on a change in pull request #15878: [BEAM-13173][Playground] Frontend Application CI/CD Scripts
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #15878:
URL: https://github.com/apache/beam/pull/15878#discussion_r747793509
##########
File path: .github/workflows/build_playground_frontend.yml
##########
@@ -0,0 +1,77 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Build And Deploy Playground Frontend Application
+
+on:
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ pull_request:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ paths: ['playground/backend/**']
+ workflow_dispatch:
+
+jobs:
+ build_playground_frontend_docker_image:
+ name: Build Playground Frontend App
+ runs-on: ubuntu-latest
+ env:
+ GO_VERSION: 1.17.0
+ BEAM_VERSION: 2.33.0
+ steps:
+ - name: Check out the repo
+ uses: actions/checkout@v2
+ - name: Set up JDK 1.8
+ uses: joschi/setup-jdk@v2
+ with:
+ java-version: '8'
+ - name: install flutter
+ uses: subosito/flutter-action@v1
+ with:
+ channel: 'stable'
+ - name: Prepare Flutter lint
+ run: "flutter pub add flutter_lints --dev"
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: Run Lint
+ run: "flutter analyze"
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: Run Tests
+ run: flutter test
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: install npm
+ uses: actions/setup-node@v2
+ with:
+ node-version: '14'
+ - name: install docker linter
+ run: npm install -g dockerlint
+ - name: lint dockerfile
+ run: dockerlint Dockerfile
+ working-directory: playground/frontend
+ - name: Setup GCP account
+ run: echo ${{ secrets.GCP_ACCESS_KEY }} | base64 -d > /tmp/gcp_access.json
Review comment:
we have some github secrets implemented for some of our other github action workflows. I just don't know how they got set up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a change in pull request #15878: [BEAM-13173][Playground] Frontend Application CI/CD Scripts
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on a change in pull request #15878:
URL: https://github.com/apache/beam/pull/15878#discussion_r746931574
##########
File path: .github/workflows/build_playground_frontend.yml
##########
@@ -0,0 +1,77 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Build And Deploy Playground Frontend Application
+
+on:
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ pull_request:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ paths: ['playground/backend/**']
+ workflow_dispatch:
+
+jobs:
+ build_playground_frontend_docker_image:
+ name: Build Playground Frontend App
+ runs-on: ubuntu-latest
+ env:
+ GO_VERSION: 1.17.0
+ BEAM_VERSION: 2.33.0
+ steps:
+ - name: Check out the repo
+ uses: actions/checkout@v2
+ - name: Set up JDK 1.8
+ uses: joschi/setup-jdk@v2
+ with:
+ java-version: '8'
+ - name: install flutter
+ uses: subosito/flutter-action@v1
+ with:
+ channel: 'stable'
+ - name: Prepare Flutter lint
+ run: "flutter pub add flutter_lints --dev"
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: Run Lint
+ run: "flutter analyze"
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: Run Tests
+ run: flutter test
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: install npm
+ uses: actions/setup-node@v2
+ with:
+ node-version: '14'
+ - name: install docker linter
+ run: npm install -g dockerlint
+ - name: lint dockerfile
+ run: dockerlint Dockerfile
+ working-directory: playground/frontend
+ - name: Setup GCP account
+ run: echo ${{ secrets.GCP_ACCESS_KEY }} | base64 -d > /tmp/gcp_access.json
Review comment:
Or you can show it once we merge the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn merged pull request #15878: [BEAM-13173][Playground] Frontend Application CI/CD Scripts
Posted by GitBox <gi...@apache.org>.
tvalentyn merged pull request #15878:
URL: https://github.com/apache/beam/pull/15878
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] snkalinin commented on pull request #15878: [BEAM-13173][Playground] Frontend Application CI/CD Scripts
Posted by GitBox <gi...@apache.org>.
snkalinin commented on pull request #15878:
URL: https://github.com/apache/beam/pull/15878#issuecomment-959193428
R: @tvalentyn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a change in pull request #15878: [BEAM-13173][Playground] Frontend Application CI/CD Scripts
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on a change in pull request #15878:
URL: https://github.com/apache/beam/pull/15878#discussion_r746931276
##########
File path: .github/workflows/build_playground_frontend.yml
##########
@@ -0,0 +1,77 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Build And Deploy Playground Frontend Application
+
+on:
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ pull_request:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ paths: ['playground/backend/**']
+ workflow_dispatch:
+
+jobs:
+ build_playground_frontend_docker_image:
+ name: Build Playground Frontend App
+ runs-on: ubuntu-latest
+ env:
+ GO_VERSION: 1.17.0
+ BEAM_VERSION: 2.33.0
+ steps:
+ - name: Check out the repo
+ uses: actions/checkout@v2
+ - name: Set up JDK 1.8
+ uses: joschi/setup-jdk@v2
+ with:
+ java-version: '8'
+ - name: install flutter
+ uses: subosito/flutter-action@v1
+ with:
+ channel: 'stable'
+ - name: Prepare Flutter lint
+ run: "flutter pub add flutter_lints --dev"
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: Run Lint
+ run: "flutter analyze"
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: Run Tests
+ run: flutter test
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: install npm
+ uses: actions/setup-node@v2
+ with:
+ node-version: '14'
+ - name: install docker linter
+ run: npm install -g dockerlint
+ - name: lint dockerfile
+ run: dockerlint Dockerfile
+ working-directory: playground/frontend
+ - name: Setup GCP account
+ run: echo ${{ secrets.GCP_ACCESS_KEY }} | base64 -d > /tmp/gcp_access.json
Review comment:
Do you have an example action job running from this workflow?
##########
File path: .github/workflows/build_playground_frontend.yml
##########
@@ -0,0 +1,77 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Build And Deploy Playground Frontend Application
+
+on:
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ pull_request:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ paths: ['playground/backend/**']
+ workflow_dispatch:
+
+jobs:
+ build_playground_frontend_docker_image:
+ name: Build Playground Frontend App
+ runs-on: ubuntu-latest
+ env:
+ GO_VERSION: 1.17.0
+ BEAM_VERSION: 2.33.0
+ steps:
+ - name: Check out the repo
+ uses: actions/checkout@v2
+ - name: Set up JDK 1.8
+ uses: joschi/setup-jdk@v2
+ with:
+ java-version: '8'
+ - name: install flutter
+ uses: subosito/flutter-action@v1
+ with:
+ channel: 'stable'
+ - name: Prepare Flutter lint
+ run: "flutter pub add flutter_lints --dev"
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: Run Lint
+ run: "flutter analyze"
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: Run Tests
+ run: flutter test
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: install npm
+ uses: actions/setup-node@v2
+ with:
+ node-version: '14'
+ - name: install docker linter
+ run: npm install -g dockerlint
+ - name: lint dockerfile
+ run: dockerlint Dockerfile
+ working-directory: playground/frontend
+ - name: Setup GCP account
+ run: echo ${{ secrets.GCP_ACCESS_KEY }} | base64 -d > /tmp/gcp_access.json
Review comment:
Do you have an example GH action job running from this workflow?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a change in pull request #15878: [BEAM-13173][Playground] Frontend Application CI/CD Scripts
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on a change in pull request #15878:
URL: https://github.com/apache/beam/pull/15878#discussion_r743804258
##########
File path: .github/workflows/build_playground_frontend.yml
##########
@@ -0,0 +1,77 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Build And Deploy Playground Frontend Application
+
+on:
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ pull_request:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ paths: ['playground/backend/**']
+ workflow_dispatch:
+
+jobs:
+ build_playground_frontend_docker_image:
+ name: Build Playground Frontend App
+ runs-on: ubuntu-latest
+ env:
+ GO_VERSION: 1.17.0
+ BEAM_VERSION: 2.33.0
+ steps:
+ - name: Check out the repo
+ uses: actions/checkout@v2
+ - name: Set up JDK 1.8
+ uses: joschi/setup-jdk@v2
+ with:
+ java-version: '8'
+ - name: install flutter
+ uses: subosito/flutter-action@v1
+ with:
+ channel: 'stable'
+ - name: Prepare Flutter lint
+ run: "flutter pub add flutter_lints --dev"
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: Run Lint
+ run: "flutter analyze"
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: Run Tests
+ run: flutter test
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: install npm
+ uses: actions/setup-node@v2
+ with:
+ node-version: '14'
+ - name: install docker linter
+ run: npm install -g dockerlint
+ - name: lint dockerfile
+ run: dockerlint Dockerfile
+ working-directory: playground/frontend
+ - name: Setup GCP account
+ run: echo ${{ secrets.GCP_ACCESS_KEY }} | base64 -d > /tmp/gcp_access.json
Review comment:
Where are the secrets/passwords coming from? Are they going to be visible in the GH action logs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a change in pull request #15878: [BEAM-13173][Playground] Frontend Application CI/CD Scripts
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on a change in pull request #15878:
URL: https://github.com/apache/beam/pull/15878#discussion_r746931826
##########
File path: .github/workflows/build_playground_frontend.yml
##########
@@ -0,0 +1,77 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Build And Deploy Playground Frontend Application
+
+on:
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ pull_request:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ paths: ['playground/backend/**']
+ workflow_dispatch:
+
+jobs:
+ build_playground_frontend_docker_image:
+ name: Build Playground Frontend App
+ runs-on: ubuntu-latest
+ env:
+ GO_VERSION: 1.17.0
+ BEAM_VERSION: 2.33.0
+ steps:
+ - name: Check out the repo
+ uses: actions/checkout@v2
+ - name: Set up JDK 1.8
+ uses: joschi/setup-jdk@v2
+ with:
+ java-version: '8'
+ - name: install flutter
+ uses: subosito/flutter-action@v1
+ with:
+ channel: 'stable'
+ - name: Prepare Flutter lint
+ run: "flutter pub add flutter_lints --dev"
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: Run Lint
+ run: "flutter analyze"
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: Run Tests
+ run: flutter test
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: install npm
+ uses: actions/setup-node@v2
+ with:
+ node-version: '14'
+ - name: install docker linter
+ run: npm install -g dockerlint
+ - name: lint dockerfile
+ run: dockerlint Dockerfile
+ working-directory: playground/frontend
+ - name: Setup GCP account
+ run: echo ${{ secrets.GCP_ACCESS_KEY }} | base64 -d > /tmp/gcp_access.json
Review comment:
if the pr needs to be merged before you can trigger the job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on a change in pull request #15878: [BEAM-13173][Playground] Frontend Application CI/CD Scripts
Posted by GitBox <gi...@apache.org>.
tvalentyn commented on a change in pull request #15878:
URL: https://github.com/apache/beam/pull/15878#discussion_r743804258
##########
File path: .github/workflows/build_playground_frontend.yml
##########
@@ -0,0 +1,77 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: Build And Deploy Playground Frontend Application
+
+on:
+ push:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ pull_request:
+ branches: ['master', 'release-*']
+ tags: 'v*'
+ paths: ['playground/backend/**']
+ workflow_dispatch:
+
+jobs:
+ build_playground_frontend_docker_image:
+ name: Build Playground Frontend App
+ runs-on: ubuntu-latest
+ env:
+ GO_VERSION: 1.17.0
+ BEAM_VERSION: 2.33.0
+ steps:
+ - name: Check out the repo
+ uses: actions/checkout@v2
+ - name: Set up JDK 1.8
+ uses: joschi/setup-jdk@v2
+ with:
+ java-version: '8'
+ - name: install flutter
+ uses: subosito/flutter-action@v1
+ with:
+ channel: 'stable'
+ - name: Prepare Flutter lint
+ run: "flutter pub add flutter_lints --dev"
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: Run Lint
+ run: "flutter analyze"
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: Run Tests
+ run: flutter test
+ working-directory: playground/frontend/
+ continue-on-error: true
+ - name: install npm
+ uses: actions/setup-node@v2
+ with:
+ node-version: '14'
+ - name: install docker linter
+ run: npm install -g dockerlint
+ - name: lint dockerfile
+ run: dockerlint Dockerfile
+ working-directory: playground/frontend
+ - name: Setup GCP account
+ run: echo ${{ secrets.GCP_ACCESS_KEY }} | base64 -d > /tmp/gcp_access.json
Review comment:
Where are the secrets/passwords coming from? Are they going to be visible in the GH action logs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org