You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/11/10 11:41:18 UTC
[GitHub] [ozone] rakeshadr opened a new pull request #2825: HDDS-5960. Change option name to bucketlayout instead of type
rakeshadr opened a new pull request #2825:
URL: https://github.com/apache/ozone/pull/2825
## What changes were proposed in this pull request?
CreateBucketHandler exposes "--type" argument, its good to reflect the layout behavior in the option name.
```
@Option(names = \{ "--type", "-t" },
description = "Allowed Bucket Types: ${COMPLETION-CANDIDATES}",
defaultValue = "OBJECT_STORE")
```
This task is to correct the option name to "-bucketlayout", "-l"
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5960
## How was this patch tested?
existing tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #2825: HDDS-5960. Change option name to bucketlayout instead of type
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #2825:
URL: https://github.com/apache/ozone/pull/2825#discussion_r746512174
##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/bucket/CreateBucketHandler.java
##########
@@ -53,8 +53,8 @@
enum AllowedBucketLayouts {FILE_SYSTEM_OPTIMIZED, OBJECT_STORE}
- @Option(names = { "--type", "-t" },
- description = "Allowed Bucket Types: ${COMPLETION-CANDIDATES}",
+ @Option(names = { "--bucketlayout", "-l" },
Review comment:
Can we simplify `bucketlayout` to `layout`? The command name `... bucket create` implies the layout is for the bucket.
Also, should we keep `--type`, `-t` as alias for compatibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on a change in pull request #2825: HDDS-5960. Change option name to bucketlayout instead of type
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on a change in pull request #2825:
URL: https://github.com/apache/ozone/pull/2825#discussion_r747252509
##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/bucket/CreateBucketHandler.java
##########
@@ -53,8 +53,8 @@
enum AllowedBucketLayouts {FILE_SYSTEM_OPTIMIZED, OBJECT_STORE}
- @Option(names = { "--type", "-t" },
- description = "Allowed Bucket Types: ${COMPLETION-CANDIDATES}",
+ @Option(names = { "--bucketlayout", "-l" },
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr merged pull request #2825: HDDS-5960. Change option name to bucketlayout instead of type
Posted by GitBox <gi...@apache.org>.
rakeshadr merged pull request #2825:
URL: https://github.com/apache/ozone/pull/2825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] adoroszlai commented on a change in pull request #2825: HDDS-5960. Change option name to bucketlayout instead of type
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #2825:
URL: https://github.com/apache/ozone/pull/2825#discussion_r747236801
##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/bucket/CreateBucketHandler.java
##########
@@ -53,8 +53,8 @@
enum AllowedBucketLayouts {FILE_SYSTEM_OPTIMIZED, OBJECT_STORE}
- @Option(names = { "--type", "-t" },
- description = "Allowed Bucket Types: ${COMPLETION-CANDIDATES}",
+ @Option(names = { "--bucketlayout", "-l" },
Review comment:
> Since the bucket layout feature is not formally released yet , can we skip the compatibility aspect ?
I don't think it's necessary then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on pull request #2825: HDDS-5960. Change option name to bucketlayout instead of type
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on pull request #2825:
URL: https://github.com/apache/ozone/pull/2825#issuecomment-966053411
> Thanks for changing it @rakeshadr. In EC branch, we introduced "-replicatonType" option for bucket default replication. We could not use "-type" as its already used for bucketlayout, and we forced to use other name "-replicationType" for replication option. With this change in, we can use "-type" for replication and that will be a consistent across. Once this is committed, I will change that later in branch.
Thanks @umamaheswararao, really glad to see the feedback:-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on pull request #2825: HDDS-5960. Change option name to bucketlayout instead of type
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on pull request #2825:
URL: https://github.com/apache/ozone/pull/2825#issuecomment-966237289
Thanks @adoroszlai , @bharatviswa504, @umamaheswararao for the reviews. I will merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on a change in pull request #2825: HDDS-5960. Change option name to bucketlayout instead of type
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on a change in pull request #2825:
URL: https://github.com/apache/ozone/pull/2825#discussion_r746528609
##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/bucket/CreateBucketHandler.java
##########
@@ -53,8 +53,8 @@
enum AllowedBucketLayouts {FILE_SYSTEM_OPTIMIZED, OBJECT_STORE}
- @Option(names = { "--type", "-t" },
- description = "Allowed Bucket Types: ${COMPLETION-CANDIDATES}",
+ @Option(names = { "--bucketlayout", "-l" },
Review comment:
Thanks @adoroszlai for the review.
Sure, I will change the name to` "layout"`
>Also, should we keep --type, -t as alias for compatibility?
Since the bucket layout feature is not formally released yet , can we skip the compatibility aspect ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] rakeshadr commented on a change in pull request #2825: HDDS-5960. Change option name to bucketlayout instead of type
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on a change in pull request #2825:
URL: https://github.com/apache/ozone/pull/2825#discussion_r747250896
##########
File path: hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/bucket/CreateBucketHandler.java
##########
@@ -53,8 +53,8 @@
enum AllowedBucketLayouts {FILE_SYSTEM_OPTIMIZED, OBJECT_STORE}
- @Option(names = { "--type", "-t" },
- description = "Allowed Bucket Types: ${COMPLETION-CANDIDATES}",
+ @Option(names = { "--bucketlayout", "-l" },
Review comment:
Thanks for the reply, then I will update the patch with the name `"layout"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] umamaheswararao commented on pull request #2825: HDDS-5960. Change option name to bucketlayout instead of type
Posted by GitBox <gi...@apache.org>.
umamaheswararao commented on pull request #2825:
URL: https://github.com/apache/ozone/pull/2825#issuecomment-966046816
Thanks for changing it @rakeshadr. In EC branch, we introduced "-replicatonType" option for bucket default replication. We could not use "-type" as its already used for bucketlayout, and we forced to use other name "-replicationType" for replication option.
With this change in, we can use "-type" for replication and that will be a consistent across. Once this is committed, I will change that later in branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org