[GitHub] [pinot] 61yao commented on a diff in pull request #10515: Allow ValueBlock length to increase in TransformFunction

["61yao (via GitHub)" <gi...@apache.org>]

61yao commented on code in PR #10515:
URL: https://github.com/apache/pinot/pull/10515#discussion_r1154029132


##########
pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/BaseTransformFunction.java:
##########
@@ -122,12 +121,16 @@ public int[][] transformToDictIdsMV(ValueBlock valueBlock) {
     throw new UnsupportedOperationException();
   }
 
+  protected void initIntValuesSV(int length) {
+    if (_intValuesSV == null || _intValuesSV.length < length) {

Review Comment:
   Do we need to do anything if _intValuesSV.length > length? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org