You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@asterixdb.apache.org by "KuiLIU (JIRA)" <ji...@apache.org> on 2018/11/13 08:04:00 UTC

[jira] [Resolved] (ASTERIXDB-2370) Inconsistent method name

     [ https://issues.apache.org/jira/browse/ASTERIXDB-2370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

KuiLIU resolved ASTERIXDB-2370.
-------------------------------
    Resolution: Fixed

> Inconsistent method name
> ------------------------
>
>                 Key: ASTERIXDB-2370
>                 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2370
>             Project: Apache AsterixDB
>          Issue Type: Improvement
>            Reporter: KuiLIU
>            Priority: Major
>
> The following method is named as "isFull".
> However, the method does set the boolean-variable full.
> Thus, rename the method as "setFull" should be more intuitive than "isFull" since "isFull" is a query asking whether the object is full or not.
> {code:java}
>     public synchronized void isFull(boolean full) {
>         this.full.set(full);
>         this.notify();
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)