You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/07 04:28:04 UTC

[GitHub] [incubator-devlake] likyh opened a new pull request, #2993: feat: change duration from text to float8

likyh opened a new pull request, #2993:
URL: https://github.com/apache/incubator-devlake/pull/2993

   # Summary
   
   <!--
   Thanks for submitting a pull request!
   
   We appreciate you spending the time to work on these changes.
   Please fill out as many sections below as possible.
   -->
   change duration from text to float8.
   
   After this fix, job e2e test can pass in pg.
   ![image](https://user-images.githubusercontent.com/3294100/188788705-d81e2610-195e-4fb3-a3eb-aee51d07faf8.png)
   (It can not pass before this fix.)
   
   
   ### Does this close any open issues?
   Closes #2977
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] klesh commented on pull request #2993: feat: change duration from text to float8

Posted by GitBox <gi...@apache.org>.

klesh commented on PR #2993:
URL: https://github.com/apache/incubator-devlake/pull/2993#issuecomment-1239438236

   Looks good, did you test it on pg?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] klesh merged pull request #2993: feat: change duration from text to float8

Posted by GitBox <gi...@apache.org>.

klesh merged PR #2993:
URL: https://github.com/apache/incubator-devlake/pull/2993


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] likyh commented on pull request #2993: feat: change duration from text to float8

Posted by GitBox <gi...@apache.org>.

likyh commented on PR #2993:
URL: https://github.com/apache/incubator-devlake/pull/2993#issuecomment-1239441984

   > Looks good, did you test it on pg?
   
   Yes. job E2E test could not pass in PG, but it can pass after changing. Migrate can also run on PG. 
   ![origin_img_v2_2a930f74-6f13-4e81-b3a2-09107deeb50g](https://user-images.githubusercontent.com/3294100/188899318-2090880e-6e53-4374-900a-fa17a1005e41.jpg)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org