[ofbiz-framework] branch trunk updated: Fixed: Fix cast error at CommunicationEventServices.groovy (OFBIZ-12801)

[pg...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

pgil pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new d31b69efc7 Fixed: Fix cast error at CommunicationEventServices.groovy (OFBIZ-12801)
d31b69efc7 is described below

commit d31b69efc70ecf31d8a8720a6eea238e0f3170a4
Author: Gil Portenseigne <gi...@nereide.fr>
AuthorDate: Fri May 5 15:21:59 2023 +0200

    Fixed: Fix cast error at CommunicationEventServices.groovy (OFBIZ-12801)
    
    Service implementation should return a Map, since `return success()` was
    misplaced within `.each`, it is ignored, and the `communicationEvents` List was
    returned instead.
    
    Thanks, Jacques for spotting and Daniel for the analysis
---
 .../party/groovyScripts/communication/CommunicationEventServices.groovy | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/applications/party/groovyScripts/communication/CommunicationEventServices.groovy b/applications/party/groovyScripts/communication/CommunicationEventServices.groovy
index 1ff1b62c34..dc45a4e8e9 100644
--- a/applications/party/groovyScripts/communication/CommunicationEventServices.groovy
+++ b/applications/party/groovyScripts/communication/CommunicationEventServices.groovy
@@ -501,8 +501,8 @@ Map sendEmailDated() {
         Map updCommEventStatusMap = [*:communicationEvent]
         updCommEventStatusMap.statusId = 'COM_COMPLETE'
         run service: 'setCommunicationEventStatus', with: updCommEventStatusMap
-        return success()
     }
+    return success()
 }
 
 /**