[GitHub] [pulsar] nodece commented on a change in pull request #8781: [issue 8337][Worker] Move initialize dlog namespace metadata to bin/pulsar

[GitBox <gi...@apache.org>]

nodece commented on a change in pull request #8781:
URL: https://github.com/apache/pulsar/pull/8781#discussion_r534052862



##########
File path: pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/Worker.java
##########
@@ -150,15 +150,8 @@ private static URI initialize(WorkerConfig workerConfig)
             admin.close();
         }
 
-        // initialize the dlog namespace
-        // TODO: move this as part of pulsar cluster initialization later
-        try {
-            return WorkerUtils.initializeDlogNamespace(internalConf);
-        } catch (IOException ioe) {
-            log.error("Failed to initialize dlog namespace with zookeeper {} at metadata service uri {} for storing function packages",
-                internalConf.getZookeeperServers(), internalConf.getBookkeeperMetadataServiceUri(), ioe);
-            throw ioe;
-        }
+        // get the dlog namespace
+        return WorkerUtils.getDlogNamespaceURI(internalConf.getZookeeperServers());

Review comment:
       I update my code, and I'm not sure if I'm doing the right thing, please let me know if have any problems.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org