You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/16 05:15:40 UTC

[GitHub] [flink-kubernetes-operator] Aitozi commented on a change in pull request #67: [FLINK-26545] Ingress rules in managed namespace

Aitozi commented on a change in pull request #67:
URL: https://github.com/apache/flink-kubernetes-operator/pull/67#discussion_r827633675



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/BaseReconciler.java
##########
@@ -60,7 +59,11 @@ private DeleteControl shutdownAndDelete(
             FlinkUtils.deleteCluster(flinkApp, kubernetesClient, true);
         }
         IngressUtils.updateIngressRules(
-                flinkApp, effectiveConfig, operatorNamespace, kubernetesClient, true);
+                flinkApp,
+                effectiveConfig,
+                flinkApp.getMetadata().getNamespace(),

Review comment:
       this do not have pass the `flinkApp.getMetadata().getNamespace()`, it can get from the `flinkApp`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org