You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/01/18 10:04:22 UTC
[GitHub] [spark] beliefer opened a new pull request #35241: [SPARK-37953][SQL] Improve the implement of `UnevaluableAggregate`
beliefer opened a new pull request #35241:
URL: https://github.com/apache/spark/pull/35241
### What changes were proposed in this pull request?
Currently, Spark provides `UnevaluableAggregate` to replace function with another function which must be exists in build-in functions, so `UnevaluableAggregate` make Spark could reuse the implement of build-in function.
However, the sub classes of `UnevaluableAggregate` looks cumbersome.
### Why are the changes needed?
Improve the implement of `UnevaluableAggregate`.
### Does this PR introduce _any_ user-facing change?
Yes. Users will see the.change of `UnevaluableAggregate`.
### How was this patch tested?
Exists test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer closed pull request #35241: [SPARK-37953][SQL] Improve the implement of `UnevaluableAggregate`
Posted by GitBox <gi...@apache.org>.
beliefer closed pull request #35241:
URL: https://github.com/apache/spark/pull/35241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer edited a comment on pull request #35241: [SPARK-37953][SQL] Improve the implement of `UnevaluableAggregate`
Posted by GitBox <gi...@apache.org>.
beliefer edited a comment on pull request #35241:
URL: https://github.com/apache/spark/pull/35241#issuecomment-1017149787
ping @gengliangwang cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #35241: [SPARK-37953][SQL] Improve the implement of `UnevaluableAggregate`
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #35241:
URL: https://github.com/apache/spark/pull/35241#issuecomment-1049591953
https://github.com/apache/spark/pull/35534 merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] beliefer commented on pull request #35241: [SPARK-37953][SQL] Improve the implement of `UnevaluableAggregate`
Posted by GitBox <gi...@apache.org>.
beliefer commented on pull request #35241:
URL: https://github.com/apache/spark/pull/35241#issuecomment-1017149787
ping @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org