You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by br...@apache.org on 2006/06/27 06:17:48 UTC
svn commit: r417335 - /maven/plugins/trunk/pom.xml
Author: brett
Date: Mon Jun 26 21:17:46 2006
New Revision: 417335
URL: http://svn.apache.org/viewvc?rev=417335&view=rev
Log:
make activation more consistent
Modified:
maven/plugins/trunk/pom.xml
Modified: maven/plugins/trunk/pom.xml
URL: http://svn.apache.org/viewvc/maven/plugins/trunk/pom.xml?rev=417335&r1=417334&r2=417335&view=diff
==============================================================================
--- maven/plugins/trunk/pom.xml (original)
+++ maven/plugins/trunk/pom.xml Mon Jun 26 21:17:46 2006
@@ -80,7 +80,13 @@
</reporting>
<profiles>
<profile>
- <id>ci</id>
+ <id>ciProfile</id>
+ <activation>
+ <property>
+ <name>enableCiProfile</name>
+ <value>true</value>
+ </property>
+ </activation>
<build>
<plugins>
<plugin>
@@ -88,7 +94,7 @@
<executions>
<execution>
<goals>
- <goal>plugin</goal>
+ <goal>check</goal>
</goals>
</execution>
</executions>
Re: svn commit: r417335 - /maven/plugins/trunk/pom.xml
Posted by Trygve Laugstøl <tr...@apache.org>.
Brett Porter wrote:
> yah, we can change the name, I was just making it consistent with the
> repository manager one I had already set up.
>
> Continuum still forks all the builds, so I'm not sure why using the
> system property would be harder, it's just an additional property you
> can use instead of -P (which I have had problems using to set multiple
> profiles before which makes the property useful).
The idea was that Continuum would inspect the profiles in the pom.xml
and could give a dropdown or a check box list of profiles for Continuum
to activate.
--
Trygve
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r417335 - /maven/plugins/trunk/pom.xml
Posted by Brett Porter <br...@apache.org>.
yah, we can change the name, I was just making it consistent with the
repository manager one I had already set up.
Continuum still forks all the builds, so I'm not sure why using the
system property would be harder, it's just an additional property you
can use instead of -P (which I have had problems using to set multiple
profiles before which makes the property useful).
- Brett
On 27/06/2006 11:17 PM, Trygve Laugstøl wrote:
> brett@apache.org wrote:
>> Author: brett
>> Date: Mon Jun 26 21:17:46 2006
>> New Revision: 417335
>>
>> URL: http://svn.apache.org/viewvc?rev=417335&view=rev
>> Log:
>> make activation more consistent
>>
>> Modified:
>> maven/plugins/trunk/pom.xml
>>
>> Modified: maven/plugins/trunk/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/maven/plugins/trunk/pom.xml?rev=417335&r1=417334&r2=417335&view=diff
>>
>> ==============================================================================
>>
>> --- maven/plugins/trunk/pom.xml (original)
>> +++ maven/plugins/trunk/pom.xml Mon Jun 26 21:17:46 2006
>> @@ -80,7 +80,13 @@
>> </reporting>
>> <profiles>
>> <profile>
>> - <id>ci</id>
>> + <id>ciProfile</id>
>> + <activation>
>> + <property>
>> + <name>enableCiProfile</name>
>> + <value>true</value>
>> + </property>
>> + </activation>
>
> I don't get this. Why not just call the profile "ci" or "ciProfile" and
> just activate it with -Pci? What's the point in using the system
> property to enable it?
>
> Continuum should probably natively support the concept of profiles and
> enable them per build configuration, which makes system property-based
> profiles a bit harder.
>
> --
> Trygve
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
--
Brett Porter <br...@apache.org>
Apache Maven - http://maven.apache.org/
Better Builds with Maven - http://library.mergere.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r417335 - /maven/plugins/trunk/pom.xml
Posted by Trygve Laugstøl <tr...@apache.org>.
brett@apache.org wrote:
> Author: brett
> Date: Mon Jun 26 21:17:46 2006
> New Revision: 417335
>
> URL: http://svn.apache.org/viewvc?rev=417335&view=rev
> Log:
> make activation more consistent
>
> Modified:
> maven/plugins/trunk/pom.xml
>
> Modified: maven/plugins/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/pom.xml?rev=417335&r1=417334&r2=417335&view=diff
> ==============================================================================
> --- maven/plugins/trunk/pom.xml (original)
> +++ maven/plugins/trunk/pom.xml Mon Jun 26 21:17:46 2006
> @@ -80,7 +80,13 @@
> </reporting>
> <profiles>
> <profile>
> - <id>ci</id>
> + <id>ciProfile</id>
> + <activation>
> + <property>
> + <name>enableCiProfile</name>
> + <value>true</value>
> + </property>
> + </activation>
I don't get this. Why not just call the profile "ci" or "ciProfile" and
just activate it with -Pci? What's the point in using the system
property to enable it?
Continuum should probably natively support the concept of profiles and
enable them per build configuration, which makes system property-based
profiles a bit harder.
--
Trygve
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org