You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Adrien Grand (JIRA)" <ji...@apache.org> on 2017/01/18 18:33:26 UTC
[jira] [Commented] (LUCENE-7644)
FieldComparatorSource.newComparator() doesn't need to throw IOException
[ https://issues.apache.org/jira/browse/LUCENE-7644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828525#comment-15828525 ]
Adrien Grand commented on LUCENE-7644:
--------------------------------------
+1
> FieldComparatorSource.newComparator() doesn't need to throw IOException
> -----------------------------------------------------------------------
>
> Key: LUCENE-7644
> URL: https://issues.apache.org/jira/browse/LUCENE-7644
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Minor
> Attachments: LUCENE-7644.patch
>
>
> All IO operations on FieldComparator are done in .getLeafComparator(), so there's no need to declare IOException on their constructors.
> This bubbles back up and lets us remove throws clauses from a number of constructors, TopDocs.merge(), and so on.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org