You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/01/04 11:45:12 UTC

[GitHub] [ozone] adoroszlai opened a new pull request #2960: HDDS-6149. Remove unused keytabs

adoroszlai opened a new pull request #2960:
URL: https://github.com/apache/ozone/pull/2960


   ## What changes were proposed in this pull request?
   
   HDDS-5123 added pre-created keytabs in two locations:
   
    * `hadoop-ozone/dist/src/main/keytabs`
    * `hadoop-ozone/dist/src/main/compose/ozonesecure*/keytabs`.
   
   I think the ones in the second location are unused, left over from a previous state of the patch for HDDS-5123.
   
   This PR just removes the unused keytabs.
   
   https://issues.apache.org/jira/browse/HDDS-6149
   
   ## How was this patch tested?
   
   Regular CI:
   https://github.com/adoroszlai/hadoop-ozone/actions/runs/1652665882


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] sodonnel commented on pull request #2960: HDDS-6149. Remove unused keytabs

Posted by GitBox <gi...@apache.org>.
sodonnel commented on pull request #2960:
URL: https://github.com/apache/ozone/pull/2960#issuecomment-1004927263


   Checking in `hadoop-ozone/dist/target/ozone-1.3.0-SNAPSHOT/compose/ozonesecure` the docker-compose file only seems to reference keytabs in `../_keytabs`, which it mounts into the container. So I think you are correct. The keytabs in `compose/ozonesecure*/keytabs` don't seem to be referenced anywhere and can be removed.
   
   Also, all the tests pass with these files removed, further confirming they are not needed.
   
   I am not an expert in this area, but based on the above I believe this change is good.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] adoroszlai commented on pull request #2960: HDDS-6149. Remove unused keytabs

Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #2960:
URL: https://github.com/apache/ozone/pull/2960#issuecomment-1005619129


   Thanks @sodonnel for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org

[GitHub] [ozone] adoroszlai merged pull request #2960: HDDS-6149. Remove unused keytabs

Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #2960:
URL: https://github.com/apache/ozone/pull/2960


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org