You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Kevin Wilfong (Created) (JIRA)" <ji...@apache.org> on 2012/03/15 19:29:38 UTC
[jira] [Created] (HIVE-2872) Store which configs the user has
explicitly changed
Store which configs the user has explicitly changed
---------------------------------------------------
Key: HIVE-2872
URL: https://issues.apache.org/jira/browse/HIVE-2872
Project: Hive
Issue Type: Improvement
Reporter: Kevin Wilfong
Assignee: Kevin Wilfong
It would be useful to keep track of which config variables the user has explicitly changed from the values which are either default or loaded from hive-site.xml. These include config variables set using the hiveconf argument to the CLI, and via the SET command. This could be used to prevent Hive from changing a config variable which has been explicitly set by the user, and also potentially for logging to help with later debugging of failed queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2872) Store which configs the user has
explicitly changed
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2872:
------------------------------
Attachment: HIVE-2872.D2337.2.patch
kevinwilfong updated the revision "HIVE-2872 [jira] Store which configs the user has explicitly changed".
Reviewers: JIRA, njain
Removed the mapping from HiveConf, created a new method which constructs the mapping of variables which have been set using System properties, which the SessionState uses instead. Also added the comment as requested.
REVISION DETAIL
https://reviews.facebook.net/D2337
AFFECTED FILES
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
ql/src/test/results/clientpositive/overridden_confs.q.out
ql/src/test/org/apache/hadoop/hive/ql/hooks/VerifyOverriddenConfigsHook.java
ql/src/test/queries/clientpositive/overridden_confs.q
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java
ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java
> Store which configs the user has explicitly changed
> ---------------------------------------------------
>
> Key: HIVE-2872
> URL: https://issues.apache.org/jira/browse/HIVE-2872
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2872.D2337.1.patch, HIVE-2872.D2337.2.patch
>
>
> It would be useful to keep track of which config variables the user has explicitly changed from the values which are either default or loaded from hive-site.xml. These include config variables set using the hiveconf argument to the CLI, and via the SET command. This could be used to prevent Hive from changing a config variable which has been explicitly set by the user, and also potentially for logging to help with later debugging of failed queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2872) Store which configs the user has
explicitly changed
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230772#comment-13230772 ]
Phabricator commented on HIVE-2872:
-----------------------------------
njain has accepted the revision "HIVE-2872 [jira] Store which configs the user has explicitly changed".
REVISION DETAIL
https://reviews.facebook.net/D2337
BRANCH
svn
> Store which configs the user has explicitly changed
> ---------------------------------------------------
>
> Key: HIVE-2872
> URL: https://issues.apache.org/jira/browse/HIVE-2872
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2872.D2337.1.patch, HIVE-2872.D2337.2.patch
>
>
> It would be useful to keep track of which config variables the user has explicitly changed from the values which are either default or loaded from hive-site.xml. These include config variables set using the hiveconf argument to the CLI, and via the SET command. This could be used to prevent Hive from changing a config variable which has been explicitly set by the user, and also potentially for logging to help with later debugging of failed queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2872) Store which configs the user has
explicitly changed
Posted by "Kevin Wilfong (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-2872:
--------------------------------
Status: Patch Available (was: Open)
> Store which configs the user has explicitly changed
> ---------------------------------------------------
>
> Key: HIVE-2872
> URL: https://issues.apache.org/jira/browse/HIVE-2872
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2872.D2337.1.patch
>
>
> It would be useful to keep track of which config variables the user has explicitly changed from the values which are either default or loaded from hive-site.xml. These include config variables set using the hiveconf argument to the CLI, and via the SET command. This could be used to prevent Hive from changing a config variable which has been explicitly set by the user, and also potentially for logging to help with later debugging of failed queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2872) Store which configs the user has
explicitly changed
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-2872:
------------------------------
Attachment: HIVE-2872.D2337.1.patch
kevinwilfong requested code review of "HIVE-2872 [jira] Store which configs the user has explicitly changed".
Reviewers: JIRA
https://issues.apache.org/jira/browse/HIVE-2872
Config variables which are set by System properties, the hiveconf option on the CLI, and the SET command within the CLI, are recorded by the SessionState in a new variable
It would be useful to keep track of which config variables the user has explicitly changed from the values which are either default or loaded from hive-site.xml. These include config variables set using the hiveconf argument to the CLI, and via the SET command. This could be used to prevent Hive from changing a config variable which has been explicitly set by the user, and also potentially for logging to help with later debugging of failed queries.
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D2337
AFFECTED FILES
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
ql/src/test/results/clientpositive/overridden_confs.q.out
ql/src/test/org/apache/hadoop/hive/ql/hooks/VerifyOverriddenConfigsHook.java
ql/src/test/queries/clientpositive/overridden_confs.q
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java
ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/5169/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Store which configs the user has explicitly changed
> ---------------------------------------------------
>
> Key: HIVE-2872
> URL: https://issues.apache.org/jira/browse/HIVE-2872
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2872.D2337.1.patch
>
>
> It would be useful to keep track of which config variables the user has explicitly changed from the values which are either default or loaded from hive-site.xml. These include config variables set using the hiveconf argument to the CLI, and via the SET command. This could be used to prevent Hive from changing a config variable which has been explicitly set by the user, and also potentially for logging to help with later debugging of failed queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2872) Store which configs the user has
explicitly changed
Posted by "Kevin Wilfong (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-2872:
--------------------------------
Status: Patch Available (was: Open)
> Store which configs the user has explicitly changed
> ---------------------------------------------------
>
> Key: HIVE-2872
> URL: https://issues.apache.org/jira/browse/HIVE-2872
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2872.D2337.1.patch, HIVE-2872.D2337.2.patch
>
>
> It would be useful to keep track of which config variables the user has explicitly changed from the values which are either default or loaded from hive-site.xml. These include config variables set using the hiveconf argument to the CLI, and via the SET command. This could be used to prevent Hive from changing a config variable which has been explicitly set by the user, and also potentially for logging to help with later debugging of failed queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2872) Store which configs the user has
explicitly changed
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230645#comment-13230645 ]
Phabricator commented on HIVE-2872:
-----------------------------------
njain has commented on the revision "HIVE-2872 [jira] Store which configs the user has explicitly changed".
Talked to Kevin offline - no need to add appliedSystemProperties in conf.
Also, can you add a big comment in SessionState explaining overriddenConfigurations
REVISION DETAIL
https://reviews.facebook.net/D2337
> Store which configs the user has explicitly changed
> ---------------------------------------------------
>
> Key: HIVE-2872
> URL: https://issues.apache.org/jira/browse/HIVE-2872
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2872.D2337.1.patch
>
>
> It would be useful to keep track of which config variables the user has explicitly changed from the values which are either default or loaded from hive-site.xml. These include config variables set using the hiveconf argument to the CLI, and via the SET command. This could be used to prevent Hive from changing a config variable which has been explicitly set by the user, and also potentially for logging to help with later debugging of failed queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2872) Store which configs the user has
explicitly changed
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231136#comment-13231136 ]
Hudson commented on HIVE-2872:
------------------------------
Integrated in Hive-trunk-h0.21 #1314 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1314/])
HIVE-2872 Store which configs the user has explicitly changed
(Kevin Wilfng via namit) (Revision 1301347)
Result = FAILURE
namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1301347
Files :
* /hive/trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java
* /hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/processors/SetProcessor.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java
* /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/hooks/VerifyOverriddenConfigsHook.java
* /hive/trunk/ql/src/test/queries/clientpositive/overridden_confs.q
* /hive/trunk/ql/src/test/results/clientpositive/overridden_confs.q.out
> Store which configs the user has explicitly changed
> ---------------------------------------------------
>
> Key: HIVE-2872
> URL: https://issues.apache.org/jira/browse/HIVE-2872
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2872.D2337.1.patch, HIVE-2872.D2337.2.patch
>
>
> It would be useful to keep track of which config variables the user has explicitly changed from the values which are either default or loaded from hive-site.xml. These include config variables set using the hiveconf argument to the CLI, and via the SET command. This could be used to prevent Hive from changing a config variable which has been explicitly set by the user, and also potentially for logging to help with later debugging of failed queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2872) Store which configs the user has
explicitly changed
Posted by "Ashutosh Chauhan (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan updated HIVE-2872:
-----------------------------------
Fix Version/s: 0.9.0
> Store which configs the user has explicitly changed
> ---------------------------------------------------
>
> Key: HIVE-2872
> URL: https://issues.apache.org/jira/browse/HIVE-2872
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Fix For: 0.9.0
>
> Attachments: HIVE-2872.D2337.1.patch, HIVE-2872.D2337.2.patch
>
>
> It would be useful to keep track of which config variables the user has explicitly changed from the values which are either default or loaded from hive-site.xml. These include config variables set using the hiveconf argument to the CLI, and via the SET command. This could be used to prevent Hive from changing a config variable which has been explicitly set by the user, and also potentially for logging to help with later debugging of failed queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2872) Store which configs the user has
explicitly changed
Posted by "Namit Jain (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-2872:
-----------------------------
Status: Open (was: Patch Available)
> Store which configs the user has explicitly changed
> ---------------------------------------------------
>
> Key: HIVE-2872
> URL: https://issues.apache.org/jira/browse/HIVE-2872
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2872.D2337.1.patch
>
>
> It would be useful to keep track of which config variables the user has explicitly changed from the values which are either default or loaded from hive-site.xml. These include config variables set using the hiveconf argument to the CLI, and via the SET command. This could be used to prevent Hive from changing a config variable which has been explicitly set by the user, and also potentially for logging to help with later debugging of failed queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2872) Store which configs the user has
explicitly changed
Posted by "Namit Jain (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-2872:
-----------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed. Thanks Kevin
> Store which configs the user has explicitly changed
> ---------------------------------------------------
>
> Key: HIVE-2872
> URL: https://issues.apache.org/jira/browse/HIVE-2872
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2872.D2337.1.patch, HIVE-2872.D2337.2.patch
>
>
> It would be useful to keep track of which config variables the user has explicitly changed from the values which are either default or loaded from hive-site.xml. These include config variables set using the hiveconf argument to the CLI, and via the SET command. This could be used to prevent Hive from changing a config variable which has been explicitly set by the user, and also potentially for logging to help with later debugging of failed queries.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira