You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openwebbeans.apache.org by Mark Struberg <st...@yahoo.de> on 2013/01/01 20:38:51 UTC

upcoming refactoring tasks

Hi folks!

I now have a working draft for an ASM4 based interceptor proxy running.
This still misses the configuration and setup of the actual InvocationHandler handling all the interceptor stack and interceptor and decorator instance handling,

For implementing this I need to tweak the whole Interceptor handling. We have a few nasty bugs in there, e.g. do we not properly treat @PreDestroy and @PostConstruct interceptors. If an interceptor has all 3 methods @PreDestroy, @AroundInvoke and @PostConstruct, then we create 3 interceptor instances. This is fundamentally wrong.

For fixing this I need to change a few methods. For some of them I will use @predestroy and a TODO, but others have the right name, but wrong behaviour. I will refactor all those methods and add "_Remove". 


At the end of next week we should be able to remove all the old proxying logic. At this point we will find tons of unused code which we can drop later on.


There are 2 tasks which could be done in parallel

1.) If someone is interested in hacking the arquillian-container-owb, I will copy over the version from trunk to the 1.1.x branch where it can be implemented without me interrupting anyone with a broken build/refactoring.

2.) in OWB-1.2.x we will move the complete Bean creation to AnnotatedType and drop all the 'internal' one which works with native class reflection.


LieGrue,
strub