You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cxf.apache.org by spark404 <gi...@git.apache.org> on 2017/04/20 12:24:20 UTC

[GitHub] cxf pull request #265: CXF-7343 Also add InFault and OutFault interceptors

GitHub user spark404 opened a pull request:

    https://github.com/apache/cxf/pull/265

    CXF-7343 Also add InFault and OutFault interceptors

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/spark404/cxf CXF-7343

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cxf/pull/265.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #265
    
----
commit 8327f87c4594d1dc8770e04d9176c88557b291e0
Author: Hugo Trippaers <ht...@schubergphilis.com>
Date:   2017-04-20T12:17:01Z

    CXF-7343 Also add InFault and OutFault interceptors

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cxf issue #265: CXF-7343 Also add InFault and OutFault interceptors

Posted by sberyozkin <gi...@git.apache.org>.

Github user sberyozkin commented on the issue:

    https://github.com/apache/cxf/pull/265
  
    Thanks, does CXF run in-fault interceptors on the server side ? May be I'm wrong, need to double check, I thought they were only run on the client side.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cxf issue #265: CXF-7343 Also add InFault and OutFault interceptors

Posted by sberyozkin <gi...@git.apache.org>.

Github user sberyozkin commented on the issue:

    https://github.com/apache/cxf/pull/265
  
    I just checked, the in fault interceptors are not run (try to throw a Fault from the in interceptor) but the in interceptors.handleFault method is called. Ideally we'd not have the option to set the inFaultIntercptors at the server factory bean level; probably too sensitive modify the API at this stage 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cxf issue #265: CXF-7343 Also add InFault and OutFault interceptors

Posted by spark404 <gi...@git.apache.org>.

Github user spark404 commented on the issue:

    https://github.com/apache/cxf/pull/265
  
    I didn't check, but I have difficulties thinking up a case for in fault interceptors. I found the issue when adding an out fault interceptor.
    
    I added the in fault more for completeness. If somebody finds a use case at least the support is there \U0001f601


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cxf pull request #265: CXF-7343 Also add InFault and OutFault interceptors

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/cxf/pull/265


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---