You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/01/11 08:05:27 UTC
[GitHub] [cloudstack] DK101010 opened a new pull request #5848: Feat/add vdisk UUID to list volume
DK101010 opened a new pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848
Each VDisk on hard disk have got a uuid which starts with 600xx. Administrators needs this uuid often to identifies the right VDisk.
This PR get the vdisk uuid from vcenter and store it into the database as external_uuid in volume table. Also extend the listVolume response to add external_uuid.
Only new volumes are affected by this implementation.
**Two sql update steps are necessary:**
1.
ALTER TABLE volumes ADD COLUMN external_uuid varchar(40) DEFAULT null;
2.
DROP VIEW IF EXISTS `cloud`.`volume_view`;
CREATE VIEW `cloud`.`volume_view` AS
SELECT
volumes.id,
volumes.uuid,
volumes.name,
volumes.device_id,
volumes.volume_type,
volumes.provisioning_type,
volumes.size,
volumes.min_iops,
volumes.max_iops,
volumes.created,
volumes.state,
volumes.attached,
volumes.removed,
volumes.display_volume,
volumes.format,
volumes.path,
volumes.chain_info,
volumes.external_uuid,
account.id account_id,
account.uuid account_uuid,
account.account_name account_name,
account.type account_type,
domain.id domain_id,
domain.uuid domain_uuid,
domain.name domain_name,
domain.path domain_path,
projects.id project_id,
projects.uuid project_uuid,
projects.name project_name,
data_center.id data_center_id,
data_center.uuid data_center_uuid,
data_center.name data_center_name,
data_center.networktype data_center_type,
vm_instance.id vm_id,
vm_instance.uuid vm_uuid,
vm_instance.name vm_name,
vm_instance.state vm_state,
vm_instance.vm_type,
user_vm.display_name vm_display_name,
volume_store_ref.size volume_store_size,
volume_store_ref.download_pct,
volume_store_ref.download_state,
volume_store_ref.error_str,
volume_store_ref.created created_on_store,
disk_offering.id disk_offering_id,
disk_offering.uuid disk_offering_uuid,
disk_offering.name disk_offering_name,
disk_offering.display_text disk_offering_display_text,
disk_offering.use_local_storage,
disk_offering.system_use,
disk_offering.bytes_read_rate,
disk_offering.bytes_write_rate,
disk_offering.iops_read_rate,
disk_offering.iops_write_rate,
disk_offering.cache_mode,
storage_pool.id pool_id,
storage_pool.uuid pool_uuid,
storage_pool.name pool_name,
cluster.id cluster_id,
cluster.name cluster_name,
cluster.uuid cluster_uuid,
cluster.hypervisor_type,
vm_template.id template_id,
vm_template.uuid template_uuid,
vm_template.extractable,
vm_template.type template_type,
vm_template.name template_name,
vm_template.display_text template_display_text,
iso.id iso_id,
iso.uuid iso_uuid,
iso.name iso_name,
iso.display_text iso_display_text,
resource_tags.id tag_id,
resource_tags.uuid tag_uuid,
resource_tags.key tag_key,
resource_tags.value tag_value,
resource_tags.domain_id tag_domain_id,
resource_tags.account_id tag_account_id,
resource_tags.resource_id tag_resource_id,
resource_tags.resource_uuid tag_resource_uuid,
resource_tags.resource_type tag_resource_type,
resource_tags.customer tag_customer,
async_job.id job_id,
async_job.uuid job_uuid,
async_job.job_status job_status,
async_job.account_id job_account_id,
host_pod_ref.id pod_id,
host_pod_ref.uuid pod_uuid,
host_pod_ref.name pod_name,
resource_tag_account.account_name tag_account_name,
resource_tag_domain.uuid tag_domain_uuid,
resource_tag_domain.name tag_domain_name
from
`cloud`.`volumes`
inner join
`cloud`.`account` ON volumes.account_id = account.id
inner join
`cloud`.`domain` ON volumes.domain_id = domain.id
left join
`cloud`.`projects` ON projects.project_account_id = account.id
left join
`cloud`.`data_center` ON volumes.data_center_id = data_center.id
left join
`cloud`.`vm_instance` ON volumes.instance_id = vm_instance.id
left join
`cloud`.`user_vm` ON user_vm.id = vm_instance.id
left join
`cloud`.`volume_store_ref` ON volumes.id = volume_store_ref.volume_id
left join
`cloud`.`disk_offering` ON volumes.disk_offering_id = disk_offering.id
left join
`cloud`.`storage_pool` ON volumes.pool_id = storage_pool.id
left join
`cloud`.`host_pod_ref` ON storage_pool.pod_id = host_pod_ref.id
left join
`cloud`.`cluster` ON storage_pool.cluster_id = cluster.id
left join
`cloud`.`vm_template` ON volumes.template_id = vm_template.id
left join
`cloud`.`vm_template` iso ON iso.id = volumes.iso_id
left join
`cloud`.`resource_tags` ON resource_tags.resource_id = volumes.id
and resource_tags.resource_type = 'Volume'
left join
`cloud`.`async_job` ON async_job.instance_id = volumes.id
and async_job.instance_type = 'Volume'
and async_job.job_status = 0
left join
`cloud`.`account` resource_tag_account ON resource_tag_account.id = resource_tags.account_id
left join
`cloud`.`domain` resource_tag_domain ON resource_tag_domain.id = resource_tags.domain_id;
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [x] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Tested in own VMware environment.
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1059675620
<b>Trillian Build Failed (tid-3499)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#discussion_r835463712
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql
##########
@@ -220,6 +220,19 @@ CREATE VIEW `cloud`.`service_offering_view` AS
GROUP BY
`service_offering`.`id`;
+
+DELIMITER //
+CREATE PROCEDURE create_external_uuid_in_volumes()
+ BEGIN
+ SELECT count(*) INTO @count FROM INFORMATION_SCHEMA.COLUMNS WHERE table_name = 'volumes' AND table_schema='cloud' AND column_name = 'external_uuid';
+ IF @count < 1 THEN ALTER TABLE cloud.volumes ADD COLUMN external_uuid VARCHAR(40) DEFAULT null;
+ END IF;
+ END //
+DELIMITER ;
+CALL create_external_uuid_in_volumes;
+DROP PROCEDURE create_external_uuid_in_volumes;
Review comment:
How about this?
````
DROP PROCEDURE IF EXISTS `cloud`.`create_external_uuid_in_volumes`();
CREATE PROCEDURE `cloud`.`create_external_uuid_in_volumes`()
BEGIN
IF NOT EXISTS ((SELECT * FROM INFORMATION_SCHEMA.COLUMNS WHERE
table_name = 'volumes' AND
table_schema='cloud' AND
column_name = 'external_uuid'))
THEN
ALTER TABLE cloud.volumes ADD COLUMN external_uuid VARCHAR(40) DEFAULT null;
END IF; END;;
CALL `cloud`.`create_external_uuid_in_volumes`();
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1073426138
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1073426031
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#discussion_r840298183
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql
##########
@@ -220,6 +220,19 @@ CREATE VIEW `cloud`.`service_offering_view` AS
GROUP BY
`service_offering`.`id`;
+
+DELIMITER //
+CREATE PROCEDURE create_external_uuid_in_volumes()
+ BEGIN
+ SELECT count(*) INTO @count FROM INFORMATION_SCHEMA.COLUMNS WHERE table_name = 'volumes' AND table_schema='cloud' AND column_name = 'external_uuid';
+ IF @count < 1 THEN ALTER TABLE cloud.volumes ADD COLUMN external_uuid VARCHAR(40) DEFAULT null;
+ END IF;
+ END //
+DELIMITER ;
+CALL create_external_uuid_in_volumes;
+DROP PROCEDURE create_external_uuid_in_volumes;
Review comment:
@DK101010
if you use stock cloudstack, the table `volumes` does not have the column, there is no issue.
if you have already added the column in your environment, you can use mysql procedure IDEMPOTENT_ADD_COLUMN which is defined in schema-41520to41600.sql.
please refer to
https://github.com/apache/cloudstack/blob/e339c4b964257c22bde238708f056bd34621446b/engine/schema/src/main/resources/META-INF/db/schema-41520to41600.sql#L127-L143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1068689782
@nvazquez a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1068721859
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1030739857
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1073847523
@DK101010 can you try @Pearl1594's approach on your env? If that works please push the changes and we'll kick a new round of tests. This is the version we are using:
````
# mysql --version
mysql Ver 15.1 Distrib 5.5.68-MariaDB, for Linux (x86_64) using readline 5.1
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#discussion_r815655866
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql
##########
@@ -220,6 +220,10 @@ CREATE VIEW `cloud`.`service_offering_view` AS
GROUP BY
`service_offering`.`id`;
+
+ALTER TABLE volumes ADD COLUMN external_uuid varchar(40) DEFAULT null;
Review comment:
this should be idem potent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1011845180
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1011844472
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1009915834
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1034591327
> @DK101010 I verified there are some conflicts that needs to be fixed, please rebase the current main branch
>
> ```
> INFO: Executing the merge now.. Git output below:
> INFO: ***********************************************************************************
> From https://github.com/apache/cloudstack
> * [new ref] refs/pull/5848/head -> pr/5848
> Auto-merging vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
> Auto-merging server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
> Auto-merging server/src/main/java/com/cloud/api/query/dao/VolumeJoinDaoImpl.java
> Auto-merging plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
> Auto-merging engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeObject.java
> Auto-merging engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql
> CONFLICT (add/add): Merge conflict in engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql
> Auto-merging api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
> Auto-merging api/src/main/java/com/cloud/storage/Volume.java
> Automatic merge failed; fix conflicts and then commit the result.
> ERROR: Merge failed, aborting.
>
> Build step 'Execute shell' marked build as failure
> New run name is '#3540-5848'
> Stopping all containers
> Finished: FAILURE
> ```
Thanks, i will do this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1059410791
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1009945685
<b>Trillian Build Failed (tid-2860)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1011843988
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1085516648
> `external_uuid` is not clear for me (maybe other users), can we use other name like `virtual_disk_uuid` ?
I guess your are right, the name is not really nice. But there are a couple of uuids for volumes and with virtual_disk_uuid some can assume that is the uuid that you can see in the VCenter, but it isn't. More accurate, it is the filename on the hard disk. But filename_uuid is also not pretty nice :D.
Therefore "external_uuid" ... this uuid plays no role if you work in CS or VCenter but it is interesting if you want to find the file.
But I see I'm a little bit inconsistent, method name and answer parameter should be the same name like the var name. :-/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1059412926
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1030739879
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1068720398
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 2896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on a change in pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
DK101010 commented on a change in pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#discussion_r840273718
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql
##########
@@ -220,6 +220,19 @@ CREATE VIEW `cloud`.`service_offering_view` AS
GROUP BY
`service_offering`.`id`;
+
+DELIMITER //
+CREATE PROCEDURE create_external_uuid_in_volumes()
+ BEGIN
+ SELECT count(*) INTO @count FROM INFORMATION_SCHEMA.COLUMNS WHERE table_name = 'volumes' AND table_schema='cloud' AND column_name = 'external_uuid';
+ IF @count < 1 THEN ALTER TABLE cloud.volumes ADD COLUMN external_uuid VARCHAR(40) DEFAULT null;
+ END IF;
+ END //
+DELIMITER ;
+CALL create_external_uuid_in_volumes;
+DROP PROCEDURE create_external_uuid_in_volumes;
Review comment:
@weizhouapache ehhhh what ? this was my first solution, What is with idem potent?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1009861202
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti removed a comment on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
sureshanaparti removed a comment on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1009861202
@blueorangutan test centos7 vmware-67u3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1009916142
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1009763577
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on a change in pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
DK101010 commented on a change in pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#discussion_r836101597
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql
##########
@@ -220,6 +220,19 @@ CREATE VIEW `cloud`.`service_offering_view` AS
GROUP BY
`service_offering`.`id`;
+
+DELIMITER //
+CREATE PROCEDURE create_external_uuid_in_volumes()
+ BEGIN
+ SELECT count(*) INTO @count FROM INFORMATION_SCHEMA.COLUMNS WHERE table_name = 'volumes' AND table_schema='cloud' AND column_name = 'external_uuid';
+ IF @count < 1 THEN ALTER TABLE cloud.volumes ADD COLUMN external_uuid VARCHAR(40) DEFAULT null;
+ END IF;
+ END //
+DELIMITER ;
+CALL create_external_uuid_in_volumes;
+DROP PROCEDURE create_external_uuid_in_volumes;
Review comment:
Nope, get also a syntax error. If it work by you, I would suggest that we add this, so that we have progress here. I will check it later what the problem with my env is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1073455983
<b>Trillian Build Failed (tid-3675)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez edited a comment on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
nvazquez edited a comment on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1073475526
Hi @DK101010 there is a problem with the SQL changes that is causing the management server to fail, can you please fix?
````
at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.<init>(CloudStackSpringContext.java:61)
at org.apache.cloudstack.spring.module.web.CloudStackContextLoaderListener.contextInitialized(CloudStackContextLoaderListener.java:51)
at org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:1067)
at org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:572)
at org.eclipse.jetty.server.handler.ContextHandler.contextInitialized(ContextHandler.java:996)
at org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:746)
at org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:379)
at org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1449)
at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1414)
at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:910)
at org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:288)
at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:524)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:110)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97)
at org.eclipse.jetty.server.handler.gzip.GzipHandler.doStart(GzipHandler.java:426)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:117)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
at org.eclipse.jetty.server.Server.start(Server.java:423)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:110)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97)
at org.eclipse.jetty.server.Server.doStart(Server.java:387)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73)
at org.apache.cloudstack.ServerDaemon.start(ServerDaemon.java:192)
at org.apache.cloudstack.ServerDaemon.main(ServerDaemon.java:107)
Caused by: java.sql.SQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'DELIMITER // CREATE PROCEDURE create_external_uuid_in_volumes() BEGIN SELE' at line 1
at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:185)
at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:87)
at com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeChecker.java:215)
... 52 more
2022-03-21 04:20:06,233 DEBUG [c.c.u.d.T.Transaction] (main:null) (logid:) Rolling back the transaction: Time = 426 Name = Upgrade; called by -TransactionLegacy.rollback:888-TransactionLegacy.removeUpTo:831-TransactionLegacy.close:655-DatabaseUpgradeChecker.upgrade:314-DatabaseUpgradeChecker.check:389-CloudStackExtendedLifeCycle.checkIntegrity:64-CloudStackExtendedLifeCycle.start:54-DefaultLifecycleProcessor.doStart:178-DefaultLifecycleProcessor.access$200:54-DefaultLifecycleProcessor$LifecycleGroup.start:356-Iterable.forEach:75-DefaultLifecycleProcessor.startBeans:155
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1068689455
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1009707100
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1033980848
@DK101010 I verified there are some conflicts that needs to be fixed, please rebase the current main branch
````
INFO: Executing the merge now.. Git output below:
INFO: ***********************************************************************************
From https://github.com/apache/cloudstack
* [new ref] refs/pull/5848/head -> pr/5848
Auto-merging vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
Auto-merging server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
Auto-merging server/src/main/java/com/cloud/api/query/dao/VolumeJoinDaoImpl.java
Auto-merging plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageProcessor.java
Auto-merging engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeObject.java
Auto-merging engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql
CONFLICT (add/add): Merge conflict in engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql
Auto-merging api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
Auto-merging api/src/main/java/com/cloud/storage/Volume.java
Automatic merge failed; fix conflicts and then commit the result.
ERROR: Merge failed, aborting.
Build step 'Execute shell' marked build as failure
New run name is '#3540-5848'
Stopping all containers
Finished: FAILURE
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1059413286
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1073475526
Hi @DK101010 there is a problem with the SQL changes that is causing the management server to fail, can you please fix?
````
Caused by: java.sql.SQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'DELIMITER // CREATE PROCEDURE create_external_uuid_in_volumes() BEGIN SELE' at line 1
at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:185)
at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:87)
at com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeChecker.java:215)
... 52 more
2022-03-21 04:20:06,233 DEBUG [c.c.u.d.T.Transaction] (main:null) (logid:) Rolling back the transaction: Time = 426 Name = Upgrade; called by -TransactionLegacy.rollback:888-TransactionLegacy.removeUpTo:831-TransactionLegacy.close:655-DatabaseUpgradeChecker.upgrade:314-DatabaseUpgradeChecker.check:389-CloudStackExtendedLifeCycle.checkIntegrity:64-CloudStackExtendedLifeCycle.start:54-DefaultLifecycleProcessor.doStart:178-DefaultLifecycleProcessor.access$200:54-DefaultLifecycleProcessor$LifecycleGroup.start:356-Iterable.forEach:75-DefaultLifecycleProcessor.startBeans:155
^C
[root@pr5848-t3680-vmware-65u2-mgmt1 ~]# ^C
[root@pr5848-t3680-vmware-65u2-mgmt1 ~]# less /var/log/cloudstack/management/management-server.log
at org.apache.cloudstack.spring.module.factory.CloudStackSpringContext.<init>(CloudStackSpringContext.java:61)
at org.apache.cloudstack.spring.module.web.CloudStackContextLoaderListener.contextInitialized(CloudStackContextLoaderListener.java:51)
at org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:1067)
at org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler.java:572)
at org.eclipse.jetty.server.handler.ContextHandler.contextInitialized(ContextHandler.java:996)
at org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:746)
at org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:379)
at org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1449)
at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1414)
at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:910)
at org.eclipse.jetty.servlet.ServletContextHandler.doStart(ServletContextHandler.java:288)
at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:524)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:110)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97)
at org.eclipse.jetty.server.handler.gzip.GzipHandler.doStart(GzipHandler.java:426)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:117)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:169)
at org.eclipse.jetty.server.Server.start(Server.java:423)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:110)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:97)
at org.eclipse.jetty.server.Server.doStart(Server.java:387)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:73)
at org.apache.cloudstack.ServerDaemon.start(ServerDaemon.java:192)
at org.apache.cloudstack.ServerDaemon.main(ServerDaemon.java:107)
Caused by: java.sql.SQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'DELIMITER // CREATE PROCEDURE create_external_uuid_in_volumes() BEGIN SELE' at line 1
at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:185)
at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:87)
at com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeChecker.java:215)
... 52 more
2022-03-21 04:20:06,233 DEBUG [c.c.u.d.T.Transaction] (main:null) (logid:) Rolling back the transaction: Time = 426 Name = Upgrade; called by -TransactionLegacy.rollback:888-TransactionLegacy.removeUpTo:831-TransactionLegacy.close:655-DatabaseUpgradeChecker.upgrade:314-DatabaseUpgradeChecker.check:389-CloudStackExtendedLifeCycle.checkIntegrity:64-CloudStackExtendedLifeCycle.start:54-DefaultLifecycleProcessor.doStart:178-DefaultLifecycleProcessor.access$200:54-DefaultLifecycleProcessor$LifecycleGroup.start:356-Iterable.forEach:75-DefaultLifecycleProcessor.startBeans:155
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1073447730
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2937
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1073448563
@blueorangutan test centos7 vmware-65u2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1073467203
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 edited a comment on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
DK101010 edited a comment on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1077674068
Hi @Pearl1594, @nvazquez,
I have checked it now with MariaDB. But my SQL continue works. For @Pearl1594 procedure I get an error on this line
`SELECT count(*) INTO @count FROM INFORMATION_SCHEMA.COLUMNS WHERE table_name = 'volumes' AND table_schema='cloud' AND column_name = 'external_uuid'`
But this line looks good.
Currently I have no idea what I can change to provocate this error. :-/
Connector Version is 8.0.19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 edited a comment on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
DK101010 edited a comment on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1073561853
> Hi @DK101010 there is a problem with the SQL changes that is causing the management server to fail, can you please fix?
>
> ```
> Caused by: java.sql.SQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'DELIMITER // CREATE PROCEDURE create_external_uuid_in_volumes() BEGIN SELE' at line 1
> at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:185)
> at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:87)
> at com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeChecker.java:215)
> ... 52 more
> 2022-03-21 04:20:06,233 DEBUG [c.c.u.d.T.Transaction] (main:null) (logid:) Rolling back the transaction: Time = 426 Name = Upgrade; called by -TransactionLegacy.rollback:888-TransactionLegacy.removeUpTo:831-TransactionLegacy.close:655-DatabaseUpgradeChecker.upgrade:314-DatabaseUpgradeChecker.check:389-CloudStackExtendedLifeCycle.checkIntegrity:64-CloudStackExtendedLifeCycle.start:54-DefaultLifecycleProcessor.doStart:178-DefaultLifecycleProcessor.access$200:54-DefaultLifecycleProcessor$LifecycleGroup.start:356-Iterable.forEach:75-DefaultLifecycleProcessor.startBeans:155
> ```
Hi @nvazquez, hmm for mysql server it works, I guess MariaDB don't like it. Therefore I would have to change my server to write a alternative solution. probably I need some time for this change.
Which maria db version is currently in use ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1073561853
> Hi @DK101010 there is a problem with the SQL changes that is causing the management server to fail, can you please fix?
>
> ```
> Caused by: java.sql.SQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'DELIMITER // CREATE PROCEDURE create_external_uuid_in_volumes() BEGIN SELE' at line 1
> at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:185)
> at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:87)
> at com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeChecker.java:215)
> ... 52 more
> 2022-03-21 04:20:06,233 DEBUG [c.c.u.d.T.Transaction] (main:null) (logid:) Rolling back the transaction: Time = 426 Name = Upgrade; called by -TransactionLegacy.rollback:888-TransactionLegacy.removeUpTo:831-TransactionLegacy.close:655-DatabaseUpgradeChecker.upgrade:314-DatabaseUpgradeChecker.check:389-CloudStackExtendedLifeCycle.checkIntegrity:64-CloudStackExtendedLifeCycle.start:54-DefaultLifecycleProcessor.doStart:178-DefaultLifecycleProcessor.access$200:54-DefaultLifecycleProcessor$LifecycleGroup.start:356-Iterable.forEach:75-DefaultLifecycleProcessor.startBeans:155
> ```
Hi @nvazquez, hmm for mysql server it works, I guess MariaDB don't like it. Therefore I would have to change my server to write a alternative solution. probably I need some time for this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1073928211
> @DK101010 can you try @Pearl1594's approach on your env? If that works please push the changes and we'll kick a new round of tests. This is the version we are using:
>
> ```
> # mysql --version
> mysql Ver 15.1 Distrib 5.5.68-MariaDB, for Linux (x86_64) using readline 5.1
> ```
Many Thanks @Pearl1594 and @nvazquez, I'll change my db server and test it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez edited a comment on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
nvazquez edited a comment on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1073475526
Hi @DK101010 there is a problem with the SQL changes that is causing the management server to fail, can you please fix?
````
Caused by: java.sql.SQLSyntaxErrorException: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'DELIMITER // CREATE PROCEDURE create_external_uuid_in_volumes() BEGIN SELE' at line 1
at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:185)
at com.cloud.utils.db.ScriptRunner.runScript(ScriptRunner.java:87)
at com.cloud.upgrade.DatabaseUpgradeChecker.runScript(DatabaseUpgradeChecker.java:215)
... 52 more
2022-03-21 04:20:06,233 DEBUG [c.c.u.d.T.Transaction] (main:null) (logid:) Rolling back the transaction: Time = 426 Name = Upgrade; called by -TransactionLegacy.rollback:888-TransactionLegacy.removeUpTo:831-TransactionLegacy.close:655-DatabaseUpgradeChecker.upgrade:314-DatabaseUpgradeChecker.check:389-CloudStackExtendedLifeCycle.checkIntegrity:64-CloudStackExtendedLifeCycle.start:54-DefaultLifecycleProcessor.doStart:178-DefaultLifecycleProcessor.access$200:54-DefaultLifecycleProcessor$LifecycleGroup.start:356-Iterable.forEach:75-DefaultLifecycleProcessor.startBeans:155
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on a change in pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#discussion_r839390013
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql
##########
@@ -356,6 +371,7 @@ CREATE VIEW `cloud`.`volume_view` AS
left join
`cloud`.`domain` resource_tag_domain ON resource_tag_domain.id = resource_tags.domain_id;
+
Review comment:
changes on line 374 and line 646 are not needed
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql
##########
@@ -220,6 +220,19 @@ CREATE VIEW `cloud`.`service_offering_view` AS
GROUP BY
`service_offering`.`id`;
+
+DELIMITER //
+CREATE PROCEDURE create_external_uuid_in_volumes()
+ BEGIN
+ SELECT count(*) INTO @count FROM INFORMATION_SCHEMA.COLUMNS WHERE table_name = 'volumes' AND table_schema='cloud' AND column_name = 'external_uuid';
+ IF @count < 1 THEN ALTER TABLE cloud.volumes ADD COLUMN external_uuid VARCHAR(40) DEFAULT null;
+ END IF;
+ END //
+DELIMITER ;
+CALL create_external_uuid_in_volumes;
+DROP PROCEDURE create_external_uuid_in_volumes;
Review comment:
@DK101010
since 4.17 is not released yet, you just need to add line
```
ALTER TABLE `cloud`.`volumes` ADD COLUMN `external_uuid` VARCHAR(40) DEFAULT NULL COMMENT 'UUID of the xxxxxx';
```
##########
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -3819,6 +3819,12 @@ private VolumeVO sendAttachVolumeCommand(UserVmVO vm, VolumeVO volumeToAttach, L
_volsDao.update(volumeToAttach.getId(), volumeToAttach);
}
+ if(answer.getContextParam("vdiskUuid") != null){
Review comment:
```suggestion
if (answer.getContextParam("vdiskUuid") != null) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1084355454
`external_uuid` is not clear for me (maybe other users), can we use other name like `virtual_disk_uuid` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on a change in pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
nvazquez commented on a change in pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#discussion_r840583894
##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql
##########
@@ -220,6 +220,19 @@ CREATE VIEW `cloud`.`service_offering_view` AS
GROUP BY
`service_offering`.`id`;
+
+DELIMITER //
+CREATE PROCEDURE create_external_uuid_in_volumes()
+ BEGIN
+ SELECT count(*) INTO @count FROM INFORMATION_SCHEMA.COLUMNS WHERE table_name = 'volumes' AND table_schema='cloud' AND column_name = 'external_uuid';
+ IF @count < 1 THEN ALTER TABLE cloud.volumes ADD COLUMN external_uuid VARCHAR(40) DEFAULT null;
+ END IF;
+ END //
+DELIMITER ;
+CALL create_external_uuid_in_volumes;
+DROP PROCEDURE create_external_uuid_in_volumes;
Review comment:
@DK101010 @weizhouapache thanks I was trying to do the same but forgot the procedure was already set. I would be +1 on using this procedure, in most cases adding the column won't be an issue, but using the idempotent addition we can prevent manual DB intervention on failing upgrades (if somehow an upgrade fails then if you execute the upgrade again all the columns that were added will fail the upgrade since cannot be added again, this can be prevented using the idempotent add)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1085688949
@DK101010
`external_uuid` is not nice but ok to me.
can you add more information in the description of api response below ? for example, `On vmware, xxxxxxxx`
`
@Param(description = "volume uuid that is given by virtualisation provider")
`
> > `external_uuid` is not clear for me (maybe other users), can we use other name like `virtual_disk_uuid` ?
>
> I guess your are right, the name is not really nice. But there are a couple of uuids for volumes and with virtual_disk_uuid some can assume that is the uuid that you can see in the VCenter, but it isn't. More accurate, it is the filename on the hard disk. But filename_uuid is also not pretty nice :D.
>
> Therefore "external_uuid" ... this uuid plays no role if you work in CS or VCenter but it is interesting if you want to find the file.
>
> But I see I'm a little bit inconsistent, method name and answer parameter should be the same name like the var name. :-/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1033551712
> Hi @DK101010 can you please fix the open comments? Also, it seems there is an issue with packaging
@nvazquez Sorry for delay, problems with my e-mail notifications. Regard packaging sounds strange that this change have an impact. Where can I check the packaging results?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1009861482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1030740028
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2470
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#discussion_r792736342
##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java
##########
@@ -3613,6 +3613,23 @@ public int getNumberOfVirtualDisks() throws Exception {
return count;
}
+ public String getVirtualDiskUUID(String datastoreVolumePath) throws Exception{
+ List<VirtualDevice> devices = (List<VirtualDevice>)_context.getVimClient().getDynamicProperty(_mor, "config.hardware.device");
+ if (devices != null && devices.size() > 0 && datastoreVolumePath != null) {
+ for (VirtualDevice device : devices) {
+ if (device instanceof VirtualDisk) {
+ if (device.getBacking() instanceof VirtualDiskFlatVer2BackingInfo){
+ VirtualDiskFlatVer2BackingInfo backingInfo =(VirtualDiskFlatVer2BackingInfo) device.getBacking();
+ if(backingInfo.getFileName().equals(datastoreVolumePath)){
+ return backingInfo.getUuid();
+ }
+ }
+ }
+ }
+ }
+ return null;
Review comment:
Just minors changes to improve readability.
```suggestion
if (CollectionUtils.isEmpty(devices) || datastoreVolumePath == null) {
return null;
}
for (VirtualDevice device : devices) {
if (device instanceof VirtualDisk && device.getBacking() instanceof VirtualDiskFlatVer2BackingInfo){
VirtualDiskFlatVer2BackingInfo backingInfo = (VirtualDiskFlatVer2BackingInfo) device.getBacking();
if(backingInfo.getFileName().equals(datastoreVolumePath)){
return backingInfo.getUuid();
}
}
}
return null;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1009891528
<b>Trillian Build Failed (tid-2856)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1009707837
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1010868720
@DK101010 , if these sql are needed they should be added to the upgrade script, in this case in schema-41610to41700.sql
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1073475196
<b>Trillian Build Failed (tid-3680)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1073825004
@DK101010 I had faced a similar issue - it seems to be related to the semi-colons. This should probably help:
```
CREATE PROCEDURE `cloud`.`create_external_uuid_in_volumes`()
BEGIN
SELECT count(*) INTO @count FROM INFORMATION_SCHEMA.COLUMNS WHERE table_name = 'volumes' AND table_schema='cloud' AND column_name = 'external_uuid'
; IF @count < 1 THEN ALTER TABLE cloud.volumes ADD COLUMN external_uuid VARCHAR(40) DEFAULT null
; END IF
; END ;
CALL `cloud`.`create_external_uuid_in_volumes`();
DROP PROCEDURE IF EXISTS `cloud`.`create_external_uuid_in_volumes`;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1059382182
@nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1059424786
<b>Trillian Build Failed (tid-3493)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 edited a comment on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
DK101010 edited a comment on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1055242247
> code looks kind of ok (one remark about the upgrade code. I wonder about the usefulness of this change, @DK101010 . The UUID is mostly usefull if you can search for it is it. Shouldn't there be a searchfield added for it on the listVolumes API?
In our workflow (at least until now) it isn't necessary to add this as search parameter, admins searching volumes with already existing parameter but need these uuids to find these volumes on hard disk for further actions.
It is a very special value and I have no clue in which use case a user goes to the hard disk, pick up a uuid and searching with that a volume in CS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DK101010 commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
DK101010 commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1055242247
> code looks kind of ok (one remark about the upgrade code. I wonder about the usefulness of this change, @DK101010 . The UUID is mostly usefull if you can search for it is it. Shouldn't there be a searchfield added for it on the listVolumes API?
In our workflow (at least until now) it isn't necessary to add this as search parameter, admins searching volumes with already existing parameter but need this uuids to find these volumes on hard disk for further actions.
It is a very special value and I have no clue in which use case a user goes to the hard disk, pick up a uuid and searching with that a volume in CS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1009861482
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1031028985
Hi @DK101010 can you please fix the open comments? Also, it seems there is an issue with packaging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1059381346
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez removed a comment on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
nvazquez removed a comment on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1068687717
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1068687717
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1073448855
@nvazquez a Trillian-Jenkins test job (centos7 mgmt + vmware-65u2) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez commented on pull request #5848: Feat/add vdisk UUID to list volume
Posted by GitBox <gi...@apache.org>.
nvazquez commented on pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#issuecomment-1073467023
@blueorangutan test centos7 vmware-65u2 keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org