You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/06/24 15:44:13 UTC
[GitHub] [airflow] bbovenzi opened a new pull request, #24637: Don't render child rows for closed groups
bbovenzi opened a new pull request, #24637:
URL: https://github.com/apache/airflow/pull/24637
On DAGs with many task groups, collapsing/expanding a group or selecting a task instance can take a really long time. This PR doesn't try to render a any child rows is their parent group is closed. This does force us to remove the open/close animation. But the page is quite a bit faster on large DAGs with many closed groups.
Profiles from 6 runs of a DAG 100 groups of 20 tasks each (2000 task * 6 runs):
Before:
<img width="772" alt="Screen Shot 2022-06-24 at 11 17 52 AM" src="https://user-images.githubusercontent.com/4600967/175570442-01a66129-b886-482b-8a8a-9315bcf603db.png">
After:
<img width="550" alt="Screen Shot 2022-06-24 at 11 19 09 AM" src="https://user-images.githubusercontent.com/4600967/175570371-b7c511f9-89a0-47a6-888a-6f498c48716f.png">
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #24637: Don't render child rows for closed groups
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24637:
URL: https://github.com/apache/airflow/pull/24637#issuecomment-1168201085
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bbovenzi merged pull request #24637: Don't render child rows for closed groups
Posted by GitBox <gi...@apache.org>.
bbovenzi merged PR #24637:
URL: https://github.com/apache/airflow/pull/24637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org