You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2008/05/17 17:11:38 UTC
DO NOT REPLY [Bug 45024] New: ab.c will not compile on VC6
https://issues.apache.org/bugzilla/show_bug.cgi?id=45024
Summary: ab.c will not compile on VC6
Product: Apache httpd-2
Version: 2.3-HEAD
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: normal
Priority: P2
Component: Build
AssignedTo: bugs@httpd.apache.org
ReportedBy: lists@glewis.com
INT_MAX is used to define MAX_REQUESTS on line 206 and requires the inclusion
of limits.h. However, limits.h is not included till line 429 and building on
VC6 goes down in flames. Furthermore, limits.h is included inside a conditional
statement #ifndef RAND_MAX. Hypothetically, if RAND_MAX is already defined, the
condition would be false and limits.h would never be included at which point I
would think all compilers would frown on it.
Since INT_MAX is used unconditionally, limits.h needs to be included before
line 206 AFAIK.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 45024] ab.c will not compile on VC6
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45024
Ruediger Pluem <rp...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #1 from Ruediger Pluem <rp...@apache.org> 2008-05-17 08:52:21 PST ---
So does the following patch fix your problem:
Index: support/ab.c
===================================================================
--- support/ab.c (Revision 657321)
+++ support/ab.c (Arbeitskopie)
@@ -193,6 +193,9 @@
#if APR_HAVE_CTYPE_H
#include <ctype.h>
#endif
+#if APR_HAVE_LIMITS_H
+#include <limits.h>
+#endif
/* ------------------- DEFINITIONS -------------------------- */
@@ -426,7 +429,6 @@
}
#ifndef RAND_MAX
-#include <limits.h>
#define RAND_MAX INT_MAX
#endif
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 45024] ab.c will not compile on VC6
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45024
Ruediger Pluem <rp...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #5 from Ruediger Pluem <rp...@apache.org> 2008-06-05 05:55:21 PST ---
Backported to 2.2.x
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 45024] ab.c will not compile on VC6
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45024
Ruediger Pluem <rp...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |FixedInTrunk, PatchAvailable
--- Comment #3 from Ruediger Pluem <rp...@apache.org> 2008-05-17 12:32:30 PST ---
Committed to trunk as r657433
(http://svn.apache.org/viewvc?rev=657433&view=rev).
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 45024] ab.c will not compile on VC6
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45024
Gregg L. Smith <li...@glewis.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |ASSIGNED
--- Comment #2 from Gregg L. Smith <li...@glewis.com> 2008-05-17 09:12:17 PST ---
(In reply to comment #1)
> So does the following patch fix your problem:
>
Yes it does, thank you.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
DO NOT REPLY [Bug 45024] ab.c will not compile on VC6
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45024
--- Comment #4 from Ruediger Pluem <rp...@apache.org> 2008-05-26 13:06:24 PST ---
Proposed for backport to 2.2.x as r660284
(http://svn.apache.org/viewvc?rev=660284&view=rev).
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org