You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2013/07/30 16:44:48 UTC

svn commit: r1508472 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java

Author: ggregory
Date: Tue Jul 30 14:44:48 2013
New Revision: 1508472

URL: http://svn.apache.org/r1508472
Log:
[CSV-99] Revert Builder implementation in CSVFormat.

Modified:
    commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java

Modified: commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java
URL: http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java?rev=1508472&r1=1508471&r2=1508472&view=diff
==============================================================================
--- commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java (original)
+++ commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java Tue Jul 30 14:44:48 2013
@@ -38,7 +38,7 @@ import java.util.Arrays;
  * </p>
  * You can extend a format through a builder. For example, to extend the Excel format with columns header, you write:
  * </p>
- * <pre>CSVFormat.EXCEL.toBuilder().withHeader(&quot;Col1&quot;, &quot;Col2&quot;, &quot;Col3&quot;).build();</pre>
+ * <pre>CSVFormat.EXCEL.toBuilder().withHeader(&quot;Col1&quot;, &quot;Col2&quot;, &quot;Col3&quot;);</pre>
  * <p>
  * You can parse through a format. For example, to parse an Excel file with columns header, you write:
  * </p>
@@ -108,7 +108,7 @@ public class CSVFormat implements Serial
      * For example for parsing or generating a CSV file on a French system the following format will be used:
      *
      * <pre>
-     * CSVFormat fmt = CSVFormat.newBuilder(EXCEL).withDelimiter(';').build();
+     * CSVFormat fmt = CSVFormat.newBuilder(EXCEL).withDelimiter(';');
      * </pre>
      * Settings are:
      * <ul>



Re: svn commit: r1508472 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java

Posted by Benedikt Ritter <br...@apache.org>.
2013/7/30 <gg...@apache.org>

> Author: ggregory
> Date: Tue Jul 30 14:44:48 2013
> New Revision: 1508472
>
> URL: http://svn.apache.org/r1508472
> Log:
> [CSV-99] Revert Builder implementation in CSVFormat.
>
> Modified:
>
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java
>
> Modified:
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java
> URL:
> http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java?rev=1508472&r1=1508471&r2=1508472&view=diff
>
> ==============================================================================
> ---
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java
> (original)
> +++
> commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java
> Tue Jul 30 14:44:48 2013
> @@ -38,7 +38,7 @@ import java.util.Arrays;
>   * </p>
>   * You can extend a format through a builder. For example, to extend the
> Excel format with columns header, you write:
>   * </p>
> - * <pre>CSVFormat.EXCEL.toBuilder().withHeader(&quot;Col1&quot;,
> &quot;Col2&quot;, &quot;Col3&quot;).build();</pre>
> + * <pre>CSVFormat.EXCEL.toBuilder().withHeader(&quot;Col1&quot;,
> &quot;Col2&quot;, &quot;Col3&quot;);</pre>
>   * <p>
>   * You can parse through a format. For example, to parse an Excel file
> with columns header, you write:
>   * </p>
> @@ -108,7 +108,7 @@ public class CSVFormat implements Serial
>       * For example for parsing or generating a CSV file on a French
> system the following format will be used:
>       *
>       * <pre>
> -     * CSVFormat fmt =
> CSVFormat.newBuilder(EXCEL).withDelimiter(';').build();
> +     * CSVFormat fmt = CSVFormat.newBuilder(EXCEL).withDelimiter(';');
>       * </pre>
>       * Settings are:
>       * <ul>
>
>
>
Thanks, for the clean up!

-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter