You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mauriziocolleluori <gi...@git.apache.org> on 2016/10/19 21:56:44 UTC
[GitHub] nifi pull request #1148: NIFI-2923 Add expression language support to Kerber...
GitHub user mauriziocolleluori opened a pull request:
https://github.com/apache/nifi/pull/1148
NIFI-2923 Add expression language support to Kerberos parameters used\u2026
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
\u2026 by processors
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mauriziocolleluori/nifi NIFI-2923
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1148.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1148
----
commit 1e7035c5f6bc730c48fc83264586f49ec90bdaf9
Author: Maurizio Colleluori <ma...@thinkbiganalytics.com>
Date: 2016-10-19T21:54:22Z
NIFI-2923 Add expression language support to Kerberos parameters used by processors
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1148: NIFI-2923 Add expression language support to Kerberos para...
Posted by mauriziocolleluori <gi...@git.apache.org>.
Github user mauriziocolleluori commented on the issue:
https://github.com/apache/nifi/pull/1148
Thank you for your feedback, I will add the necessary call to evaluateAttributeExpressions() and submit a new pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1148: NIFI-2923 Add expression language support to Kerberos para...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/1148
Hi @mauriziocolleluori,
If you still encounter issues in UI when testing properties while using expression language, please check that nifi.kerberos.krb5.file is correctly set in your nifi.properties file (and reference a readable file).
In addition, it would be great to do the same kind of modification in Kafka processors where Kerberos principal is also a property. Let me know if you are OK to do it, otherwise, I'll do it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1148: NIFI-2923 Add expression language support to Kerberos para...
Posted by mauriziocolleluori <gi...@git.apache.org>.
Github user mauriziocolleluori commented on the issue:
https://github.com/apache/nifi/pull/1148
@trixpan @pvillard31 thank you for you comments. I will look into the Kafka processors and revert back once it's done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1148: NIFI-2923 Add expression language support to Kerber...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1148
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1148: NIFI-2923 Add expression language support to Kerberos para...
Posted by bbende <gi...@git.apache.org>.
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/1148
Thank you for contributing. In addition to adding the expressionLanguageSupported flag on the property descriptors, we would also need to go through the code and find every place where the properties are evaluated, for example:
https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-hadoop-bundle/nifi-hdfs-processors/src/main/java/org/apache/nifi/processors/hadoop/AbstractHadoopProcessor.java#L283
And that would need to call evaluateAttributeExpressions().
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1148: NIFI-2923 Add expression language support to Kerber...
Posted by mauriziocolleluori <gi...@git.apache.org>.
Github user mauriziocolleluori closed the pull request at:
https://github.com/apache/nifi/pull/1148
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1148: NIFI-2923 Add expression language support to Kerberos para...
Posted by jtstorck <gi...@git.apache.org>.
Github user jtstorck commented on the issue:
https://github.com/apache/nifi/pull/1148
@mauriziocolleluori Hello, and thank you for your contribution! I am working on a JIRA (https://issues.apache.org/jira/browse/NIFI-4010) that builds upon the changes in your PR. Could you please address the remaining comments to help get your PR committed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1148: NIFI-2923 Add expression language support to Kerber...
Posted by mauriziocolleluori <gi...@git.apache.org>.
GitHub user mauriziocolleluori reopened a pull request:
https://github.com/apache/nifi/pull/1148
NIFI-2923 Add expression language support to Kerberos parameters used\u2026
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [X] Is your initial contribution a single, squashed commit?
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
\u2026 by processors
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mauriziocolleluori/nifi NIFI-2923
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1148.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1148
----
commit 1e7035c5f6bc730c48fc83264586f49ec90bdaf9
Author: Maurizio Colleluori <ma...@thinkbiganalytics.com>
Date: 2016-10-19T21:54:22Z
NIFI-2923 Add expression language support to Kerberos parameters used by processors
commit bcf98697b3e8ba7e1e38a0802183cdc302df2274
Author: Maurizio Colleluori <ma...@thinkbiganalytics.com>
Date: 2016-11-07T16:11:59Z
NIFI-2923 Added evaluation of attribute expressions for Kerberos principal and keytab
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1148: NIFI-2923 Add expression language support to Kerberos para...
Posted by mauriziocolleluori <gi...@git.apache.org>.
Github user mauriziocolleluori commented on the issue:
https://github.com/apache/nifi/pull/1148
I have recompiled and added expression language support (with expected evaluation on read) for both principal and keytab. However when I add any expression language to one of such attributes (in a Hive or HDFS processor on a kerberized Nifi instance) a tooltip says that the attribute has not been set. It looks like some UI validation is still not recognising the expression language as valid. How do I overcome this problem? Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1148: NIFI-2923 Add expression language support to Kerberos para...
Posted by trixpan <gi...@git.apache.org>.
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/1148
@mauriziocolleluori thank you for the contribution.
any intent on addressing @pvillard31 's comment? While a positive answer is more than welcome, a negative answer is also welcome... all we need to know is if this is ready to review or if you still plan to address the comments.
Cheers!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1148: NIFI-2923 Add expression language support to Kerberos para...
Posted by jtstorck <gi...@git.apache.org>.
Github user jtstorck commented on the issue:
https://github.com/apache/nifi/pull/1148
@mauriziocolleluori I've cherry-picked your commits into my branch, and will be submitting a PR that includes your commits along with mine (for [NIFI-4010](https://issues.apache.org/jira/browse/NIFI-4010)). Thank you for your contribution to Apache NiFi!
When my PR is merged to master, your PR will be closed along with mine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---