You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2023/03/20 17:02:35 UTC
[GitHub] [shardingsphere] terrymanu opened a new issue, #24699: Discuss whether to use native junit 5 assertions instead of hamcrest
terrymanu opened a new issue, #24699:
URL: https://github.com/apache/shardingsphere/issues/24699
The native JUnit 5.x's assertions are already good enough, and are somewhat different from the usage habits of Hamcrest.
The error message of Hamcrest's `assertThat` is placed in the first parameter, while the native JUnit assertions place the error message in the last parameter.
In order to maintain a consistent usage experience, I would like to use the native JUnit assertions instead of Hamcrest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed issue #24699: Discuss whether to use native junit 5 assertions instead of hamcrest
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu closed issue #24699: Discuss whether to use native junit 5 assertions instead of hamcrest
URL: https://github.com/apache/shardingsphere/issues/24699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #24699: Discuss whether to use native junit 5 assertions instead of hamcrest
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on issue #24699:
URL: https://github.com/apache/shardingsphere/issues/24699#issuecomment-1483978990
The junit 5's assertEquals still put expected value on 1st param, actual on 2nd param. It think Hamcrest's assertThat is better to understand the code. So I just give up to remove hamcrest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org