You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by at...@apache.org on 2019/02/06 19:36:48 UTC

[samza] branch master updated: SAMZA-2098: Samza sql shell: Fix the LOG typo

This is an automated email from the ASF dual-hosted git repository.

atoomula pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/samza.git


The following commit(s) were added to refs/heads/master by this push:
     new 88ce78f  SAMZA-2098: Samza sql shell: Fix the LOG typo
88ce78f is described below

commit 88ce78f829d9b763e2a7c93dbe46350693c4d932
Author: Weiqing Yang <ya...@gmail.com>
AuthorDate: Wed Feb 6 11:36:42 2019 -0800

    SAMZA-2098: Samza sql shell: Fix the LOG typo
    
    Author: Weiqing Yang <ya...@gmail.com>
    
    Reviewers: atoomula
    
    Closes #907 from weiqingy/dev and squashes the following commits:
    
    5f9a22c5 [Weiqing Yang] minor code adjustment
    662b70a9 [Weiqing Yang] fix the LOG typo
---
 .../main/java/org/apache/samza/sql/client/cli/CliShell.java  | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/samza-sql-shell/src/main/java/org/apache/samza/sql/client/cli/CliShell.java b/samza-sql-shell/src/main/java/org/apache/samza/sql/client/cli/CliShell.java
index 98c6e1d..a726cf1 100755
--- a/samza-sql-shell/src/main/java/org/apache/samza/sql/client/cli/CliShell.java
+++ b/samza-sql-shell/src/main/java/org/apache/samza/sql/client/cli/CliShell.java
@@ -34,7 +34,8 @@ import org.jline.terminal.TerminalBuilder;
 import org.jline.utils.AttributedStringBuilder;
 import org.jline.utils.AttributedStyle;
 import org.jline.utils.InfoCmp;
-import org.jline.utils.Log;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import java.io.File;
 import java.io.IOException;
@@ -47,6 +48,7 @@ import java.util.*;
  * The shell UI.
  */
 class CliShell {
+  private static final Logger LOG = LoggerFactory.getLogger(CliShell.class);
   private final Terminal terminal;
   private final PrintWriter writer;
   private final LineReader lineReader;
@@ -223,7 +225,7 @@ class CliShell {
           }
         } catch (ExecutorException e) {
           writer.println("Error: " + e);
-          Log.error("Error in {}: ", command.getCommandType(), e);
+          LOG.error("Error in {}: ", command.getCommandType(), e);
           writer.flush();
         }
       }
@@ -443,7 +445,7 @@ class CliShell {
         ExecutionStatus execStatus = executor.queryExecutionStatus(id);
         status = execStatus.name();
       } catch (ExecutorException e) {
-        Log.error("Error in commandLs: ", e);
+        LOG.error("Error in commandLs: ", e);
       }
 
       int cmdStartIdx = 0;
@@ -515,7 +517,7 @@ class CliShell {
         executions.remove(id);
       } catch (ExecutorException e) {
         writer.println("Error: " + e);
-        Log.error("Error in commandRm: ", e);
+        LOG.error("Error in commandRm: ", e);
       }
     }
     writer.flush();
@@ -579,7 +581,7 @@ class CliShell {
         writer.println(String.format("Request to stop execution %d was sent.", id));
       } catch (ExecutorException e) {
         writer.println("Error: " + e);
-        Log.error("Error in commandStop: ", e);
+        LOG.error("Error in commandStop: ", e);
       }
     }
     writer.flush();