[GitHub] [pinot] walterddr commented on a diff in pull request #10559: Make v2 bytes value displayed same as v1 hex string

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10559:
URL: https://github.com/apache/pinot/pull/10559#discussion_r1159260062


##########
pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/QueryRunnerTestBase.java:
##########
@@ -181,6 +182,9 @@ protected void compareRowEquals(List<Object[]> resultRows, List<Object[]> expect
         }
         return Double.compare(ld, rd);
       } else if (l instanceof String) {
+        if (r instanceof byte[]) {

Review Comment:
   ah. got it... so we want to make it hex string. that sound like a good plan



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org