[GitHub] [iceberg] danielcweeks commented on pull request #4806: Fix invalid Stream to Iterable conversion

[GitBox <gi...@apache.org>]

danielcweeks commented on PR #4806:
URL: https://github.com/apache/iceberg/pull/4806#issuecomment-1135190360

   @findepi Do you have more context on what the issue is here.  I may be reading this wrong but the new and old approaches appear to be equivalent.  Both approaches result in a function returning an iterator that is only traversed once.  If the intent is to allow for multiple iterations, `.collect(Collections.toList())` would be preferable to avoid recomputing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org