You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/03/05 17:26:27 UTC
[GitHub] [pulsar] chrismiller opened a new issue #6484:
pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
chrismiller opened a new issue #6484: pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
URL: https://github.com/apache/pulsar/issues/6484
**Describe the bug**
The pulsar-client-admin-2.5.0.jar available on Maven Central incorrectly contains an unshaded protobuf dependency.
**To Reproduce**
Steps to reproduce the behavior:
1. Unzip https://repo1.maven.org/maven2/org/apache/pulsar/pulsar-client-admin/2.5.0/pulsar-client-admin-2.5.0.jar and observe that there are protobuf classes are under the com.google.protobuf.* package.
**Expected behavior**
The protobuf classes should be shaded, under org.apache.pulsar.shade.come.google.protobuf.*
**Screenshots**
**Additional context**
This causes a collsiion with the (newer, v3.7.0) version we already depend on in our project, resulting in NoSuchMethodError failures at runtime.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6484:
pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6484: pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
URL: https://github.com/apache/pulsar/issues/6484#issuecomment-613252829
Get it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jerrypeng edited a comment on issue #6484:
pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
Posted by GitBox <gi...@apache.org>.
jerrypeng edited a comment on issue #6484: pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
URL: https://github.com/apache/pulsar/issues/6484#issuecomment-600413743
I think the reason was because to support ProtobufSchema correctly in PulsarClient. If a user gives the client a generated Protobuf object, the client needs to have Protobuf classes at the same classpath as the user given Protobuf Object. If we use provides a protobuf object to the client but the included protobuf dependencies are all shaded, then there will be "NoClassDefError"s thrown as none of the internal protobuf class with be at the expected classpath.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] chrismiller commented on issue #6484:
pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
Posted by GitBox <gi...@apache.org>.
chrismiller commented on issue #6484: pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
URL: https://github.com/apache/pulsar/issues/6484#issuecomment-601628401
If a user is providing a protobuf object to the client, then chances are they already have their preferred version of Protobuf on their classpath though? Would it be better to exclude the protobuf classes from the Pulsar jar and require the user to include an appropriate version on their classpath themselves or would that then cause problems on the Pulsar side of things?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jerrypeng commented on issue #6484:
pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
Posted by GitBox <gi...@apache.org>.
jerrypeng commented on issue #6484: pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
URL: https://github.com/apache/pulsar/issues/6484#issuecomment-600413743
I think the reason was because is to support ProtobufSchema correctly. If a user gives the client and generated Protobuf object, the client needs to have Protobuf classes at the same classpath as the user given Protobuf Object. If we use provides a protobuf object to the client but the included protobuf dependencies are all shaded, then there will be "NoClassDefError"s thrown as none of the internal protobuf class with be at the expected classpath.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] sijie commented on issue #6484:
pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
Posted by GitBox <gi...@apache.org>.
sijie commented on issue #6484: pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
URL: https://github.com/apache/pulsar/issues/6484#issuecomment-613224299
I think we can try to make the protobuf schema dependencies as provided.
@jiazhai @gaoran10 let's pick this up the coming week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] yjshen removed a comment on issue #6484:
pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
Posted by GitBox <gi...@apache.org>.
yjshen removed a comment on issue #6484: pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
URL: https://github.com/apache/pulsar/issues/6484#issuecomment-595666076
I will check on this later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jiazhai commented on issue #6484:
pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6484: pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
URL: https://github.com/apache/pulsar/issues/6484#issuecomment-595569817
@yjshen Would you please help check this issue?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jerrypeng edited a comment on issue #6484:
pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
Posted by GitBox <gi...@apache.org>.
jerrypeng edited a comment on issue #6484: pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
URL: https://github.com/apache/pulsar/issues/6484#issuecomment-600413743
I think the reason was because to support ProtobufSchema correctly in PulsarClient. If a user gives the client a generated Protobuf object, the client needs to have Protobuf classes at the same classpath as the user given Protobuf Object. If a user provides a protobuf object to the client but the included protobuf dependencies are all shaded, then there will be "NoClassDefError"s thrown as none of the internal protobuf class with be at the expected classpath.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] lanwen commented on issue #6484:
pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
Posted by GitBox <gi...@apache.org>.
lanwen commented on issue #6484: pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
URL: https://github.com/apache/pulsar/issues/6484#issuecomment-601686473
Hello, faced this issue. Is there any workaround to exclude these protobuf classes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] eric-poitras commented on issue #6484:
pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
Posted by GitBox <gi...@apache.org>.
eric-poitras commented on issue #6484: pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
URL: https://github.com/apache/pulsar/issues/6484#issuecomment-606671832
We are having the issue too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #6484:
pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6484: pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
URL: https://github.com/apache/pulsar/issues/6484#issuecomment-598134821
The unshaded part was introduced deliberately by https://github.com/apache/pulsar/pull/3184/files#diff-9de37f4080556c0ee70ef82b066396f7R120-R122.
@jerrypeng since you added these, any ideas on why not shading the protobuf classes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] jerrypeng edited a comment on issue #6484:
pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
Posted by GitBox <gi...@apache.org>.
jerrypeng edited a comment on issue #6484: pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
URL: https://github.com/apache/pulsar/issues/6484#issuecomment-600413743
I think the reason was because to support ProtobufSchema correctly in PulsarClient. If a user gives the client and generated Protobuf object, the client needs to have Protobuf classes at the same classpath as the user given Protobuf Object. If we use provides a protobuf object to the client but the included protobuf dependencies are all shaded, then there will be "NoClassDefError"s thrown as none of the internal protobuf class with be at the expected classpath.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar] yjshen commented on issue #6484:
pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6484: pulsar-client-admin-2.5.0.jar contains an unshaded protobuf dependency
URL: https://github.com/apache/pulsar/issues/6484#issuecomment-595666076
I will check on this later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services