[GitHub] mistercrunch closed pull request #5596: [sql lab - explore flow] make sure groupby is empty

[GitBox <gi...@apache.org>]

mistercrunch closed pull request #5596: [sql lab - explore flow] make sure groupby is empty
URL: https://github.com/apache/incubator-superset/pull/5596
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/assets/src/SqlLab/components/ExploreResultsButton.jsx b/superset/assets/src/SqlLab/components/ExploreResultsButton.jsx
index 493b103c24..07d7e5349f 100644
--- a/superset/assets/src/SqlLab/components/ExploreResultsButton.jsx
+++ b/superset/assets/src/SqlLab/components/ExploreResultsButton.jsx
@@ -91,18 +91,15 @@ class ExploreResultsButton extends React.PureComponent {
       .done((resp) => {
         const columns = this.getColumns();
         const data = JSON.parse(resp);
-        const mainGroupBy = columns.filter(d => d.is_dim)[0];
         const formData = {
           datasource: `${data.table_id}__table`,
           metrics: [],
+          groupby: [],
           viz_type: 'table',
           since: '100 years ago',
           all_columns: columns.map(c => c.name),
           row_limit: 1000,
         };
-        if (mainGroupBy) {
-          formData.groupby = [mainGroupBy.name];
-        }
         this.props.actions.addInfoToast(t('Creating a data source and creating a new tab'));
 
         // open new window for data visualization


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org