You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by "itsdheerajdp (via GitHub)" <gi...@apache.org> on 2024/01/28 06:39:44 UTC

[PR] Fixes: Community Icon Hover Effect [dolphinscheduler-website]

itsdheerajdp opened a new pull request, #945:
URL: https://github.com/apache/dolphinscheduler-website/pull/945

   **Current Behavior**
   When hovering over the community icons, a grey background appears which doesn't perfectly fit the icon, causing an undesirable visual effect.
   
   [current_behavior.webm](https://github.com/apache/dolphinscheduler-website/assets/107138786/e0718121-3ccb-4391-a1e9-784c45bcdb19)
   
   
   **Proposed Solution:**
   To address this issue, we recommend updating the styles for the `.home-community-buttons` class on hover, active, and focus states. This ensures a clean and seamless appearance without any unwanted background effects.
   
   **Behavior after changes:**
   
   [Behavior_after_changes.webm](https://github.com/apache/dolphinscheduler-website/assets/107138786/c2e98e7b-5f4e-4d63-8686-2999c6990972)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fixes: Community Icon Hover Effect [dolphinscheduler-website]

Posted by "itsdheerajdp (via GitHub)" <gi...@apache.org>.

itsdheerajdp commented on code in PR #945:
URL: https://github.com/apache/dolphinscheduler-website/pull/945#discussion_r1470644234


##########
src/views/Home/community.scss:
##########


Review Comment:
   @devosend please have a look , I updated the PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fixes: Community Icon Hover Effect [dolphinscheduler-website]

Posted by "zhongjiajie (via GitHub)" <gi...@apache.org>.

zhongjiajie commented on PR #945:
URL: https://github.com/apache/dolphinscheduler-website/pull/945#issuecomment-1915859070

   Do you have time to take a look with this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fixes: Community Icon Hover Effect [dolphinscheduler-website]

Posted by "zhongjiajie (via GitHub)" <gi...@apache.org>.

zhongjiajie commented on PR #945:
URL: https://github.com/apache/dolphinscheduler-website/pull/945#issuecomment-1925028302

   @itsdheerajdp thanks for your contribution, and looking forward your further's


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fixes: Community Icon Hover Effect [dolphinscheduler-website]

Posted by "itsdheerajdp (via GitHub)" <gi...@apache.org>.

itsdheerajdp commented on code in PR #945:
URL: https://github.com/apache/dolphinscheduler-website/pull/945#discussion_r1470627150


##########
src/views/Home/community.scss:
##########


Review Comment:
   Sure , I'll Update PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fixes: Community Icon Hover Effect [dolphinscheduler-website]

Posted by "devosend (via GitHub)" <gi...@apache.org>.

devosend commented on code in PR #945:
URL: https://github.com/apache/dolphinscheduler-website/pull/945#discussion_r1470509471


##########
src/views/Home/community.scss:
##########


Review Comment:
   You need two spaces instead of four.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fixes: Community Icon Hover Effect [dolphinscheduler-website]

Posted by "devosend (via GitHub)" <gi...@apache.org>.

devosend merged PR #945:
URL: https://github.com/apache/dolphinscheduler-website/pull/945


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org