[GitHub] clebertsuconic commented on a change in pull request #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #2427: ARTEMIS-2170 Optimized CoreMessage's checkProperties and cleanupInternalProperties methods
URL: https://github.com/apache/activemq-artemis/pull/2427#discussion_r248872930
 
 

 ##########
 File path: artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/TypedProperties.java
 ##########
 @@ -318,6 +313,30 @@ public synchronized boolean containsProperty(final SimpleString key) {
       }
    }
 
+   public synchronized boolean removeProperty(Predicate<SimpleString> propertyNamePredicate) {
 
 Review comment:
   I am a bit confused. you said you're optimizing, although this is a new method. what I am missing?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services