[GitHub] zeppelin pull request #3216: [ZEPPELIN-3167]

[NicolasRouquette <gi...@git.apache.org>]

GitHub user NicolasRouquette opened a pull request:

    https://github.com/apache/zeppelin/pull/3216

    [ZEPPELIN-3167]

    ### What is this PR for?
    
    Split the R assignment in two steps, evaluation and assignment,
    such that the tryCatch in the R eval loop can detect errors
    and report them to Zeppelin.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
    * https://issues.apache.org/jira/browse/ZEPPELIN-3167
    
    ### How should this be tested?
    * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
    * Strongly recommended: add automated unit tests for any new or changed behavior
    * Outline any manual steps to test the PR here.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicolasRouquette/zeppelin master-ZEPPELIN-3167

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3216
    
----
commit 83ada910d19d6f7ca94a90f9ebf3ffa83f65eb6b
Author: Nicolas F Rouquette <ni...@...>
Date:   2018-11-03T18:19:35Z

    Split the assignment into two steps, evaluation and assignment, such that the tryCatch in the eval loop can detect and report errors back to Zeppelin

----


---

[GitHub] zeppelin issue #3216: [ZEPPELIN-3167]

[Leemoonsoo <gi...@git.apache.org>]

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/3216
  
    Thanks @NicolasRouquette for the contribution.
    Looks like CI test is failing at
    
    ```
    Results :
    
    Failed tests: 
      SparkRInterpreterTest.testSparkRInterpreter:88 expected:<SUCCESS> but was:<ERROR>
    
    Tests run: 106, Failures: 1, Errors: 0, Skipped: 0
    ```
    
    Could you check and try make the test pass?


---