[arrow-julia] branch main updated: #453 fix typeo introduced in #389 (#454)

[ba...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

baumgold pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-julia.git


The following commit(s) were added to refs/heads/main by this push:
     new 7044e19  #453 fix typeo introduced in #389 (#454)
7044e19 is described below

commit 7044e19849382129e0712133ee5ebb13310f53ee
Author: Ben Baumgold <49...@users.noreply.github.com>
AuthorDate: Tue Jun 6 14:17:28 2023 -0400

    #453 fix typeo introduced in #389 (#454)
    
    I introduced this bug in #389 - my apologies.  Fixes #453.
---
 src/ArrowTypes/src/ArrowTypes.jl | 4 ++--
 src/ArrowTypes/test/tests.jl     | 2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/ArrowTypes/src/ArrowTypes.jl b/src/ArrowTypes/src/ArrowTypes.jl
index 6e77c1c..6dee157 100644
--- a/src/ArrowTypes/src/ArrowTypes.jl
+++ b/src/ArrowTypes/src/ArrowTypes.jl
@@ -119,8 +119,8 @@ This will then be available to access by overloading `ArrowTypes.JuliaType(::Val
 function arrowmetadata end
 const EMPTY_STRING = ""
 arrowmetadata(T) = EMPTY_STRING
-arrowmetadata(::Type{Union{T,Missing}}) where {T} = arrowmetadata{T}
-arrowmetadata(::Type{Union{T,Nothing}}) where {T} = arrowmetadata{T}
+arrowmetadata(::Type{Union{T,Missing}}) where {T} = arrowmetadata(T)
+arrowmetadata(::Type{Union{T,Nothing}}) where {T} = arrowmetadata(T)
 arrowmetadata(::Type{Nothing}) = EMPTY_STRING
 arrowmetadata(::Type{Missing}) = EMPTY_STRING
 arrowmetadata(::Type{Any}) = EMPTY_STRING
diff --git a/src/ArrowTypes/test/tests.jl b/src/ArrowTypes/test/tests.jl
index 26f3945..0c257dc 100644
--- a/src/ArrowTypes/test/tests.jl
+++ b/src/ArrowTypes/test/tests.jl
@@ -38,6 +38,8 @@ end
 @test !ArrowTypes.hasarrowname(Int)
 
 @test ArrowTypes.arrowmetadata(Int) == ""
+@test ArrowTypes.arrowmetadata(Union{Nothing,Int}) == ""
+@test ArrowTypes.arrowmetadata(Union{Missing,Int}) == ""
 
 @test ArrowTypes.JuliaType(1) === nothing
 @test ArrowTypes.JuliaType(1, Int) === nothing