You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Pallav Kulshreshtha <pa...@gmail.com> on 2017/02/14 04:56:04 UTC

Re: Review Request 56488: Hive2: Invalid query execution not handled properly

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56488/
-----------------------------------------------------------

(Updated Feb. 14, 2017, 4:56 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, and Rohit Choudhary.


Summary (updated)
-----------------

Hive2: Invalid query execution not handled properly


Bugs: AMBARI-19938
    https://issues.apache.org/jira/browse/AMBARI-19938


Repository: ambari


Description
-------

- Showing notification on getting error. 
- Other code re-factor


Diffs
-----

  contrib/views/hive20/src/main/resources/ui/app/adapters/query.js e519e64 
  contrib/views/hive20/src/main/resources/ui/app/controllers/settings.js PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 1787cc7 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff 
  contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-table.hbs 4d8524e 
  contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs e0ceaa2 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5b2b5c2 

Diff: https://reviews.apache.org/r/56488/diff/


Testing
-------

manually tested.


Thanks,

Pallav Kulshreshtha