You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/11/16 11:21:24 UTC
[GitHub] [camel-k] squakez opened a new issue #2751: Remove deprecated code
squakez opened a new issue #2751:
URL: https://github.com/apache/camel-k/issues/2751
We have a few deprecated things around the code we may fix in the next releases:
- [ ] Remove older config flags (ie, `secret` and `configmap` flag)
- [ ] Remove `DeprecatedConfigMap` in `master` addon trait
- [ ] Remove `Timeout` in `MavenSpec`
- [ ] Remove `Kit` from `IntegrationSpec`
- [ ] Remove `Flow` from `KameletSpec`
- [ ] Remove `NewFilteredSharedInformerFactory`
@astefanutti @nicolaferraro can you please confirm we should be fine removing all this stuff?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on issue #2751: Remove deprecated code
Posted by GitBox <gi...@apache.org>.
astefanutti commented on issue #2751:
URL: https://github.com/apache/camel-k/issues/2751#issuecomment-970190900
> > That looks good to me. There is also the _container_ trait configuration parameters related to health checks that are deprecated and that we may want to remove as well.
>
> I think it was deprecated quite recently. I'd wait for at least one more major upgrade before removing that one.
Right, that sounds good. The others you've listed are older enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on issue #2751: Remove deprecated code
Posted by GitBox <gi...@apache.org>.
squakez commented on issue #2751:
URL: https://github.com/apache/camel-k/issues/2751#issuecomment-970189623
> That looks good to me. There is also the _container_ trait configuration parameters related to health checks that are deprecated and that we may want to remove as well.
I think it was deprecated quite recently. I'd wait for at least one more major upgrade before removing that one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] phantomjinx commented on issue #2751: Remove deprecated code
Posted by GitBox <gi...@apache.org>.
phantomjinx commented on issue #2751:
URL: https://github.com/apache/camel-k/issues/2751#issuecomment-991030249
Looking at e2e tests, `property-file` also appears deprecated too.
```
Warn: --configmap has been deprecated. You should use --config configmap:my-configmap instead.
Warn: --secret has been deprecated. You should use --config secret:my-secret instead.
Warn: --property-file has been deprecated. You should use --property file:/path
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] astefanutti commented on issue #2751: Remove deprecated code
Posted by GitBox <gi...@apache.org>.
astefanutti commented on issue #2751:
URL: https://github.com/apache/camel-k/issues/2751#issuecomment-970176648
That looks good to me. There is also the _container_ trait configuration parameters related to health checks that are deprecated and that we may want to remove as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez closed issue #2751: Remove deprecated code
Posted by GitBox <gi...@apache.org>.
squakez closed issue #2751:
URL: https://github.com/apache/camel-k/issues/2751
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org