You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@freemarker.apache.org by chrisrueger <gi...@git.apache.org> on 2016/12/27 20:53:21 UTC
[GitHub] incubator-freemarker pull request #16: Add OSGI MANIFEST.MF during ide-depen...
GitHub user chrisrueger opened a pull request:
https://github.com/apache/incubator-freemarker/pull/16
Add OSGI MANIFEST.MF during ide-dependencies
Hi Daniel,
as discussed in https://www.mail-archive.com/dev@freemarker.incubator.apache.org/msg00687.html I finally found time to commit the changes.
Basically what the 4 commits are doing:
1. during build of target ide-dependencies the META-INF folder inside generated freemarker.jar is extracted
2. for that I adjusted the build.xml and README to point out this change. The ide-dependencies target now requires the freemarker.jar to be present. before it was not needed.
**Why is this useful?**
Because I need the META-INF/MANIFEST.MF in my Eclipse / OSGI at **development time** so that other bundles in the same Eclipse workspace recognize my Freemarker Workspace project (which I imported before based on the README description).
In our company we have a Eclipse / OSGI product and we would like to include the Freemarker source code project directly in eclipse. This makes it much easier to contribute to Freemarker, because we can directly test it during our own development.
Best regards,
Christoph
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chrisrueger/incubator-freemarker 2.3-gae
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-freemarker/pull/16.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #16
----
commit 1d59baef4d9d12ee61085ae096afe0219a5dbadc
Author: Christoph <ch...@christophs-mbp.fritz.box>
Date: 2016-12-27T19:56:33Z
Extract META-INF folder with files like MANIFEST.MF from freemarker.jar and put it in base directory for eclipse
commit 835800962b8126eb4a250451017f595467e52d48
Author: chrisrueger <ch...@gmail.com>
Date: 2016-12-27T19:58:26Z
Extract META-INF folder with files like MANIFEST.MF from freemarker.jar and put it in base directory for eclipse
commit 8067aad2c1a7cf02383bb1b36f845ee706958008
Author: chrisrueger <ch...@gmail.com>
Date: 2016-12-27T20:38:38Z
correcting section about IDE-SETUP in README: now java clean jar is required because the unpacking of the META-INF folder requires the freemarker.jar to be present which is removed by clean. also remove the META-INF folder for the ant clean target
commit 312522ed011cd1c4a688f96659714561ef465b46
Author: chrisrueger <ch...@gmail.com>
Date: 2016-12-27T20:44:43Z
adding META-INF folder to .gitignore
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-freemarker pull request #16: Add OSGI MANIFEST.MF during ide-depen...
Posted by ddekany <gi...@git.apache.org>.
Github user ddekany commented on a diff in the pull request:
https://github.com/apache/incubator-freemarker/pull/16#discussion_r93977405
--- Diff: README ---
@@ -138,7 +138,7 @@ different version or an entierly different IDE, still read this, and try to
apply it to your development environment:
- Install Ant and Ivy, if you haven't yet; see earlier.
-- From the command line, run `ant clean javacc ide-dependencies`. (Note that
+- From the command line, run `ant clean jar javacc ide-dependencies`. (Note that
--- End diff --
`jar` implies `javacc`, so `javacc` can be omitted.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-freemarker pull request #16: Add OSGI MANIFEST.MF during ide-depen...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-freemarker/pull/16
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---